Skip to content

[Due for payment 2025-07-23] [$250] HybridApp SignIn page - Send hybridAppSettings via native method #65684

Closed

Description

@Julesssss

From @war-in :

Part of the HybridApp SignIn page refactor. We're moving some code outside of the main PR to keep it as small as possible

We no longer want to send hybridAppSettings through initial props because it caused unwanted rerenders when clicking r in metro (initialisation happened twice and new sign-in page logic was broken)
Now, we expose getHybridAppSettings method in HybridAppModule, which sends us settings once per ND lifetime

PRs:

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021942684589212998358
  • Upwork Job ID: 1942684589212998358
  • Last Price Increase: 2025-07-08
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Jul 8, 2025
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 8, 2025
  3. melvin-bot commented on Jul 8, 2025

    @melvin-bot
  4. changed the title [-]HybridApp SignIn page - Send hybridAppSettings via native method[/-] [+][$250] HybridApp SignIn page - Send hybridAppSettings via native method[/+] on Jul 8, 2025
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 8, 2025
  6. melvin-bot commented on Jul 8, 2025

    @melvin-bot

    Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

  7. melvin-bot commented on Jul 8, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  8. Julesssss commented on Jul 8, 2025

    @Julesssss
    ContributorAuthor

    Hi @fedirjh, I assigned you here as reviewer of #65442 and https://github.com/Expensify/Mobile-Expensify/pull/13614. AdHoc builds are in progress

  9. Julesssss commented on Jul 11, 2025

    @Julesssss
    ContributorAuthor

    Both PRs merged 🎉

  10. Julesssss commented on Jul 11, 2025

    @Julesssss
    ContributorAuthor

    Reopening for @fedirjh C+ payment next week

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 16, 2025
  12. changed the title [-][$250] HybridApp SignIn page - Send hybridAppSettings via native method[/-] [+][Due for payment 2025-07-23] [$250] HybridApp SignIn page - Send hybridAppSettings via native method[/+] on Jul 16, 2025
  13. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.81-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fedirjh requires payment through NewDot Manual Requests
    • @war-in does not require payment (Contractor)
  14. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    @fedirjh @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. laurenreidexpensify commented on Aug 6, 2025

    @laurenreidexpensify
    Contributor

    $250 approved in New Expensify for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions