[Due for payment 2025-08-05] [Due for payment 2025-07-30] [Due for payment 2025-07-25] [Due for payment 2025-07-22] [Multi-Files Drag-and-Drop] Follow-ups and code cleanup

This is a part of Multi-Files Drag-and-Drop project. #58723

PRs:
#64323 (reverted, but some minor issues were reported)
#64941
#65316

follow-ups:

cleanup:

Multi files attachments carousel #65316 (comment)

investigate:

Multi files attachments carousel #65316 (comment) / Multi files attachments carousel #65316 (comment) (if still reproducible) - NOT REPRODUCIBLE
Multi files attachments carousel #65316 (comment) (if still reproducible) - NOT REPRODUCIBLE
Multi files attachments carousel #65316 (comment) (performance)
[Internal QA] Stage 1: Restyle drop zones #61523 (comment)
Multi file attachments #64323 (comment)

One problem: #65264 (comment)

I think it should display the Add receipt If the transaction doesn't have receipt

Screen.Recording.2025-07-09.at.23.41.20.mov

@lakchote

@lakchote Could I get assigned to this issue to continue following this feature?

I think it should display the Add receipt If the transaction doesn't have receipt

Screen.Recording.2025-07-09.at.23.41.20.mov

yes, I see your point - but like mentioned it was discussed on Slack - I will tag you in the thread

@jamesdeanexpensify

@jamesdeanexpensify @RachCHopkins #64941 (comment)
answering your questions here:

the link with the anchor works properly on Safari and Chrome/chromium based browsers, so it can be used here
Do we need any more info? I think the info in the help section is sufficient unless you want to list all supported files types explicitly

@koko57

I think the info in the help section should mention all supported file types explicitly. Do you have that list @koko57? And then maybe @RachCHopkins could update? Or Maddy can help! LMK Rach.

Here's the specific section of the help article we're referencing, for posterity: https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense#option-4-bulk-upload-receipts-desktop-only

@jamesdeanexpensify

@jamesdeanexpensify yes - but it turns out that we need to discuss one if of them is valid: #65847 (comment)

so, please let's wait for the confirmation from @lakchote

@jamesdeanexpensify

@jamesdeanexpensify ~~here are the allowed extensions: jpg, jpeg, png, gif, pdf, html, txt, rtf, doc, docx, htm, tiff, tif, xml.~~

#65847 (comment)

~~and we should add heic and heif now~~

EDIT: here are the expensions:

['heif', 'heic', 'jpg', 'jpeg', 'gif', 'png', 'pdf', 'htm', 'html', 'text', 'rtf', 'doc', 'tif', 'tiff', 'msword', 'zip', 'xml', 'message'],

@RachCHopkins

Thanks! @RachCHopkins lmk if you're able to handle this update:

adding these specific supported extensions: ['heif', 'heic', 'jpg', 'jpeg', 'gif', 'png', 'pdf', 'htm', 'html', 'text', 'rtf', 'doc', 'tif', 'tiff', 'msword', 'zip', 'xml', 'message']

to this part of the help page: https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense#option-4-bulk-upload-receipts-desktop-only

Otherwise, I've got an ongoing GH with Maddy that I can add it to! Thanks again.

@koko57

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

File ordering + cleanup #66812

If no regressions arise, payment will be issued on 2025-08-05. 🎊

For reference, here are some details about the assignees on this issue:

@koko57 does not require payment (Contractor)
@DylanDylann requires payment through NewDot Manual Requests

@koko57

@chrispader the changes were added in #65316. I decided to create a new component just for adding new files in the composer to handle the validation logic. The old AttachmentMod for previewing the files from the chat works like it worked previously, I just removed the logic that is no longer necessary

hey @koko57 thanks for the info! In #65245 and recent PRs i migrated all of the AttachmentModals to a single screen with dynamic content based on the route and use case.

To make this work, all of the use cases - like showing attachments or previews for attachments to send, profile/workspace/report avatars - must be unified in one base component.

Therefore, i'll have to re-integrate the multi attachment logic into the AttachmentModal code like previously while also fixing #65317. Do you know if this was the only issue with the previous AttachmentModal re-write?

@chrispader

@chrispader Sorry that my changes interfere with your refactor plans. Yeah, the only issue with the attachment modal was #65317 - but it's solved in the useFilesValidation hook. If you have any questions or need some help - just ping me or reach me on Slack

@koko57

@koko57 thanks! It's all good. Actually, as part of merging your recent changes, i already separated the flows for showing vs. sending an attachment, so i should be able to easily adapt this.

Also, since i already have two separate sub-components for the flows, you won't need to do any follow-up PR for removing the validation logic from the AttachmentModal component, as i already removed file validation for simply showing an attachment there.

@twisterdotcom

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@koko57

Payment Summary

Upwork Job

Contributor: @koko57 is from an agency-contributor and not due payment
Reviewer: @DylanDylann owed $1250 via NewDot

BugZero Checklist (@twisterdotcom)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have verified the PR was not reverted
I have applied any discounts due to bugs/regressions introduced by this PR
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Is this $125 now because of the revert, or still $250 as a new PR?

@lakchote

@lakchote @twisterdotcom This issue addressed multiple bugs across 5 PRs, none of which were reverted. Additionally, some PRs fixed more than one bug. Given the scope of the work, I believe it’s reasonable to adjust the price accordingly.

#65264
#66061
#65847
#66150
#66812

@DylanDylann

Hi @DylanDylann, sorry for the wait here. If all of these reviews need to be paid as part of this issue, and given they all edited multiple files and took a normal amount of review, we should pay out $250 each IMO. This is not an insignificant amount of work. I have updated the payment summary accordingly. Please request $1250 for this assuming you haven't requested for these anywhere else.

@DylanDylann

$1,250 approved for @DylanDylann

@DylanDylann

$1250 approved to @DylanDylann

Navigation Menu

Repository navigation

[Due for payment 2025-08-05] [Due for payment 2025-07-30] [Due for payment 2025-07-25] [Due for payment 2025-07-22] [Multi-Files Drag-and-Drop] Follow-ups and code cleanup #65722

43 remaining items

Payment Summary

BugZero Checklist (@twisterdotcom)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2025-08-05] [Due for payment 2025-07-30] [Due for payment 2025-07-25] [Due for payment 2025-07-22] [Multi-Files Drag-and-Drop] Follow-ups and code cleanup #65722

Description

Activity

DylanDylann commented on Jul 9, 2025

DylanDylann commented on Jul 9, 2025

DylanDylann commented on Jul 9, 2025

koko57 commented on Jul 9, 2025

koko57 commented on Jul 10, 2025

jamesdeanexpensify commented on Jul 10, 2025

koko57 commented on Jul 10, 2025

koko57 commented on Jul 11, 2025

jamesdeanexpensify commented on Jul 11, 2025

43 remaining items

melvin-bot commented on Jul 29, 2025

chrispader commented on Jul 30, 2025

koko57 commented on Jul 30, 2025

chrispader commented on Jul 30, 2025

melvin-bot commented on Aug 5, 2025

melvin-bot commented on Aug 5, 2025

Payment Summary

BugZero Checklist (@twisterdotcom)

twisterdotcom commented on Aug 6, 2025

DylanDylann commented on Aug 6, 2025

twisterdotcom commented on Aug 12, 2025

JmillsExpensify commented on Oct 14, 2025

quinthar commented on Oct 16, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions