Skip to content

[Due for payment 2025-08-20] [$250] Tag - After deleting all tags, the “x selected” buttons do not disappear #65839

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.79-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6468221
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause Internal Team
Device used: OnePlus 9 PRO/Android 14, iPhone 12 PRO/iOS 18.5/Safari
App Component: Workspace Settings

Action Performed:

Prerequisites:
Create a WS, enable Tag, add 2 of any tag

Steps:

  1. Open NewDot app
  2. Go to select your WS-> Tags
  3. Go to Select mode
  4. Select all tags
  5. Click on “x selected” -> Delete tags - Delete
  6. Click on “Add tag”
  7. Add any tag

Expected Result:

After deleting all tags, the “x selected” button disappears and goes to “Add tag” mode when adding a new tag

Actual Result:

After deleting all tags, the “x selected” button does not disappear and when adding a new tag it does not go into add mode, but stays in select mode

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021943612669906840803
  • Upwork Job ID: 1943612669906840803
  • Last Price Increase: 2025-07-11
  • Automatic offers:
    • allgandalf | Reviewer | 108033118
    • twilight2294 | Contributor | 108033123
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 10, 2025
  2. github-actions commented on Jul 10, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jul 10, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. mountiny commented on Jul 10, 2025

    @mountiny
    Contributor

    @SzymczakJ Looking

  7. mountiny commented on Jul 11, 2025

    @mountiny
    Contributor

    Per this discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1752144194076579 this is already in production

  8. 34 remaining items

  9. changed the title [-][$250] Tag - After deleting all tags, the “x selected” buttons do not disappear[/-] [+][Due for payment 2025-08-20] [$250] Tag - After deleting all tags, the “x selected” buttons do not disappear[/+] on Aug 13, 2025
  10. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-20. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    @allgandalf @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. allgandalf commented on Aug 15, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A, since this a recent bug from changes in core component. So hard for the original authors to point out that their changes caused this

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/537727

    Regression Test Proposal

    Precondition:

    Test:

    Only for small screen:

    1. Open NewDot app
    2. Go to select your workspace -> Go to Tags
    3. Go to Select mode
    4. Select all tags
    5. Click on “x selected” -> Delete tags - Delete

    Verify that After deleting all tags, the “x selected” button disappears and then normal view of empty tags appears

    Do we agree 👍 or 👎

  14. Christinadobrzyn commented on Aug 19, 2025

    @Christinadobrzyn
    Contributor
  15. Christinadobrzyn commented on Aug 20, 2025

    @Christinadobrzyn
    Contributor

    Payment day! No regressions - payment summary here - #65839 (comment)

    Closing! TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions