You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-20] [$250] Tag - After deleting all tags, the “x selected” buttons do not disappear #65839
Version Number: 9.1.79-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6468221 Email or phone of affected tester (no customers):sustinov@applausemail.com Issue reported by: Applause Internal Team Device used: OnePlus 9 PRO/Android 14, iPhone 12 PRO/iOS 18.5/Safari App Component: Workspace Settings
Action Performed:
Prerequisites:
Create a WS, enable Tag, add 2 of any tag
Steps:
Open NewDot app
Go to select your WS-> Tags
Go to Select mode
Select all tags
Click on “x selected” -> Delete tags - Delete
Click on “Add tag”
Add any tag
Expected Result:
After deleting all tags, the “x selected” button disappears and goes to “Add tag” mode when adding a new tag
Actual Result:
After deleting all tags, the “x selected” button does not disappear and when adding a new tag it does not go into add mode, but stays in select mode
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Tag - After deleting all tags, the “x selected” buttons do not disappear[/-][+][Due for payment 2025-08-20] [$250] Tag - After deleting all tags, the “x selected” buttons do not disappear[/+]on Aug 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, since this a recent bug from changes in core component. So hard for the original authors to point out that their changes caused this
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
github-actions commentedon Jul 10, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 10, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 10, 2025
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 10, 2025
💬 A slack conversation has been started in #expensify-open-source
mountiny commentedon Jul 10, 2025
@SzymczakJ Looking
mountiny commentedon Jul 11, 2025
Per this discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1752144194076579 this is already in production
34 remaining items
[-][$250] Tag - After deleting all tags, the “x selected” buttons do not disappear[/-][+][Due for payment 2025-08-20] [$250] Tag - After deleting all tags, the “x selected” buttons do not disappear[/+]melvin-bot commentedon Aug 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 13, 2025
@allgandalf @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allgandalf commentedon Aug 15, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, since this a recent bug from changes in core component. So hard for the original authors to point out that their changes caused this
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/537727
Regression Test Proposal
Precondition:
Test:
Only for small screen:
Verify that After deleting all tags, the “x selected” button disappears and then normal view of empty tags appears
Do we agree 👍 or 👎
Christinadobrzyn commentedon Aug 19, 2025
Payment tomorrow
Regression test https://github.com/Expensify/Expensify/issues/537727
payment summary #65839 (comment)
Christinadobrzyn commentedon Aug 20, 2025
Payment day! No regressions - payment summary here - #65839 (comment)
Closing! TY!