[Awaiting Checklist] [$250] Notifications -"Reimbursement was cancelled" instead of Cancelled the payment on notification

@MariaHCD

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.80-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6485626&group_by=cases:section_id&group_order=asc&group_id=295000
Email or phone of affected tester (no customers): ibellicotest+3001@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 (Hybrid App)
App Component: Notifications

Action Performed:

Prerequisite:
-Have two accounts opened on two different devices or environments.
-User A logs in on the Android app
-User B has at least one workspace with delayed submissions and approvals enabled.

Open the Expensify app.
Log in as User A
As User B, invite User A as member of a workspace.
As User A, open the new workspace.
Create a manual expense.
As User B, submit, approve and pay the expense.
Open the just paid expense, and tap on "More"
Tap on "Cancel Payment"
As User A, wait until receiving notification showing the last action.
Note that notifications shows "The reimbursement was cancelled" instead of "Cancelled the payment".
Open notification.
Note that system message on report shows "Cancelled the payment"

Expected Result:

Notification received when admin of workspace cancels a payment should display a "Cancelled the payment" message.

Actual Result:

Notification received when admin of workspace cancels a payment, displays a "The reimbursement was cancelled" message, instead of "Cancelled the payment". System message on report, shows the correct "Cancelled the payment" message.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6885338_1752282052182.Reimbursement.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021944828203188143701
Upwork Job ID: 1944828203188143701
Last Price Increase: 2025-08-04

Issue Owner

Current Issue Owner: @MariaHCD

@garrettmknight

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~021944828203188143701

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Notification received when admin of workspace cancels a payment, displays a "The reimbursement was cancelled" message, instead of "Cancelled the payment". System message on report, shows the correct "Cancelled the payment" message.

What is the root cause of that problem?

The notification's message is displayed is the message?.[0].text of the action (The reimbursement was cancelled)

App/android/app/src/main/java/com/expensify/chat/customairshipextender/CustomNotificationProvider.java

Line 226 in ea46ec6

    
           String message = alert != null ? alert : messageData.get("message").getList().get(0).getMap().get("text").getString();

While in the App, we displayed a custom text is Cancelled the payment

App/src/libs/ReportUtils.ts

Line 3416 in ea46ec6

    
           return translateLocal('iou.adminCanceledRequest', {manager: payerOrApproverName, amount: formattedAmount});

What changes do you think we should make in order to solve the problem?

The backend should update the message text of REIMBURSEMENTDEQUEUED action to cancelled the payment and we also need to update this in the optimistic data here to align with the backend data.

App/src/libs/ReportUtils.ts

Line 3480 in ea46ec6

message: [

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

We can verify if the action is REIMBURSEMENTDEQUEUED and customise the notification's message to match the one displayed on the report screen.

App/android/app/src/main/java/com/expensify/chat/customairshipextender/CustomNotificationProvider.java

Line 226 in ea46ec6

    
           String message = alert != null ? alert : messageData.get("message").getList().get(0).getMap().get("text").getString();

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@mkzie2

@mkzie2's proposal looks fine to me. They pointed out the correct RCA and suggested a good solution.

In my opinion, the BE fix is sufficient for this issue. However, aligning the optimistic data is also not a bad idea. It will help our optimistic data appear more accurate. I’ll leave it up to the internal engineer to decide whether we should update the optimistic data.

🎀👀🎀 C+ reviewed

@MariaHCD

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@garrettmknight

@garrettmknight Could you help process payment to me for reviewing #68138? And then we are good to close this issue

@DylanDylann

@DylanDylann can do - can you complete the checklist as the reviewer?

@DylanDylann

Payment Summary:

Reviewer: @DylanDylann $250 via NewDot

I think we don'tt need the checklist in this issue, we only remove the redundant logic

Request when you're ready then!

Confirming payment summary here is accurate: #66020 (comment)

@DylanDylann

$250 approved for @DylanDylann

Navigation Menu

Repository navigation

[Awaiting Checklist] [$250] Notifications -"Reimbursement was cancelled" instead of Cancelled the payment on notification #66020

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

43 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Awaiting Checklist] [$250] Notifications -"Reimbursement was cancelled" instead of Cancelled the payment on notification #66020

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 14, 2025

melvin-bot commented on Jul 14, 2025

melvin-bot commented on Jul 14, 2025

mkzie2 commented on Jul 15, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

DylanDylann commented on Jul 18, 2025

melvin-bot commented on Jul 18, 2025

43 remaining items

DylanDylann commented on Sep 9, 2025

garrettmknight commented on Sep 10, 2025

garrettmknight commented on Sep 10, 2025

DylanDylann commented on Sep 10, 2025

garrettmknight commented on Sep 10, 2025

trjExpensify commented on Oct 29, 2025

garrettmknight commented on Oct 29, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions