You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Debug - RHP back button navigates to the previous tab instead of returning to the previous RHP #66119
Version Number: 9.1.81-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#66022 Email or phone of affected tester (no customers):jjsdionjsodi@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Other
Action Performed:
Go to staging.expensify.com
Open testing tool via CMD+D.
Enable Debug mode.
Close the menu.
Go to workspace chat.
Click on the report header.
Click Debug.
Switch betwen JSON, Details and Actions tab.
Click RHP back button.
Expected Result:
RHP back button will close.
Actual Result:
RHP back button navigates to the previous tab instead of returning to the previous RHP.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
RHP back button navigates to the previous tab instead of returning to the previous RHP
What is the root cause of that problem?
This is not a deploy blocker, this problem was hidden for sometime since the switch functionality was broken. we do not pass backTo param to navigation.goBack in the back button, this leads to the previous tab being shown since that is in the stack:
Oh you are right I have double checked how the create expense flow works with the tabs and this is the samae behaviour so now we just matched that. I think that is expected then!
Activity
github-actions commentedon Jul 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 15, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 15, 2025
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 15, 2025
💬 A slack conversation has been started in #expensify-open-source
twilight2294 commentedon Jul 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
RHP back button navigates to the previous tab instead of returning to the previous RHP
What is the root cause of that problem?
This is not a deploy blocker, this problem was hidden for sometime since the switch functionality was broken. we do not pass
backToparam tonavigation.goBackin the back button, this leads to the previous tab being shown since that is in the stack:App/src/pages/Debug/Report/DebugReportPage.tsx
Lines 233 to 236 in 7323ec5
What changes do you think we should make in order to solve the problem?
We need to pass
backToprop to the function and also pass it while navigating to the debug page:App/src/pages/ReportDetailsPage.tsx
Lines 506 to 512 in 7323ec5
Then in
DebugReportPage:We also need to update routes and also fix this for other pages as well in the debug section if problem exits there too
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
mountiny commentedon Jul 15, 2025
I think we can demote this one as its minor and in debug tool that is used in staging mainly
Related to #66022 @thelullabyy @hungvu193 can you take a look please
hungvu193 commentedon Jul 15, 2025
I noticed this during testing. When I checked the onBackPress function it's
Navigation.goBackand I thought it was expected mountiny commentedon Jul 15, 2025
Oh you are right I have double checked how the create expense flow works with the tabs and this is the samae behaviour so now we just matched that. I think that is expected then!