You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Split - Splitted expense can be constantly splitted again. #66120
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Remove original transaction from search snapshot optimistically #65420: This PR rewrote the split-transaction flow by removing the original transaction from snapshots, and that change likely also removed the flag used to mark children as ‘already split’, so the More menu still shows the Split action.
@rinej Do you agree with this comment that pointed to your PR as the root cause? If someone can confirm that reverting that PR fixes the problem, let's go ahead and revert it.
@jponikarchuk I am not able to reproduce this locally. I split the expense once, but there is not an option to split either new transaction an additional time.
On Staging, I don't even have the option to split:
@lakchote@garrettmknight is this something to do with "Phase 2" rollout of Split? I thought we were still going to show Edit split or something in the more menu to get back to the split screen to recalculate the splits? 🤔
@lakchote@garrettmknight is this something to do with "Phase 2" rollout of Split? I thought we were still going to show Edit split or something in the more menu to get back to the split screen to recalculate the splits? 🤔
Phase 2 of Splits is not live yet. We will present the user with the splits edit table on existing splits when Phase 2 is live.
Also, like @tgolen said in their comment here, I'm unable to reproduce the issue on my environment with the latest changes.
iirc it was a technical decision we made to keep the data for splits in phase 1 clean, so when we got to phase 2, we could reference the original transaction ID to show the split children in the split table view. If we'd have allowed splitting again, then we'd end up with Split > Create Trans 2 & 3 with Transaction 1 as the originalTransaction > Split > Create Trans 4 & 5 with Trans 2 as the originalTransaction.
Editing split transactions in Phase 2 should be online shortly and solve for this.
Activity
melvin-bot commentedon Jul 15, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 15, 2025
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 15, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nabi-ebrahimi commentedon Jul 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split - Splitted expense can be constantly splitted again.
What is the root cause of that problem?
It comes from this PR. We missed adding
onyxTransaction.commentto the list of selector checks.App/src/libs/TransactionUtils/index.ts
Lines 1649 to 1664 in ea46ec6
We get the comment from here
As we didn't add the comment to the selector checklist, we don't get the updated transaction with updated comment. so the following condition is true.
And the split option is added to the list of options here
App/src/libs/ReportSecondaryActionUtils.ts
Lines 614 to 616 in ea46ec6
What changes do you think we should make in order to solve the problem?
We need to update
App/src/components/MoneyRequestHeader.tsx
Lines 95 to 113 in ea46ec6
add
comment: onyxTransaction.commentto the list.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
rushatgabhane commentedon Jul 15, 2025
@BlameGPT please find the cause
BlameGPT commentedon Jul 15, 2025
Who let the bugs out? 🐛
If not above, check these
tgolen commentedon Jul 15, 2025
@rinej Do you agree with this comment that pointed to your PR as the root cause? If someone can confirm that reverting that PR fixes the problem, let's go ahead and revert it.
tgolen commentedon Jul 15, 2025
@jponikarchuk I am not able to reproduce this locally. I split the expense once, but there is not an option to split either new transaction an additional time.
On Staging, I don't even have the option to split:
trjExpensify commentedon Jul 16, 2025
@lakchote @garrettmknight is this something to do with "Phase 2" rollout of Split? I thought we were still going to show
Edit splitor something in the more menu to get back to the split screen to recalculate the splits? 🤔lakchote commentedon Jul 16, 2025
Phase 2 of Splits is not live yet. We will present the user with the splits edit table on existing splits when Phase 2 is live.
Also, like @tgolen said in their comment here, I'm unable to reproduce the issue on my environment with the latest changes.
trjExpensify commentedon Jul 16, 2025
Okay, in which case, why isn't the split button appearing on expenses that have been split?
garrettmknight commentedon Jul 16, 2025
iirc it was a technical decision we made to keep the data for splits in phase 1 clean, so when we got to phase 2, we could reference the original transaction ID to show the split children in the split table view. If we'd have allowed splitting again, then we'd end up with Split > Create Trans 2 & 3 with Transaction 1 as the originalTransaction > Split > Create Trans 4 & 5 with Trans 2 as the originalTransaction.
Editing split transactions in Phase 2 should be online shortly and solve for this.
garrettmknight commentedon Jul 16, 2025
But taking it back to the bug in the OP, this shouldn't be allowed at this point and it's a regression because it wasn't previously.
trjExpensify commentedon Jul 16, 2025
Okay, I'm with Tim and Lucien that I can't repro the bug in the OP.
tgolen commentedon Jul 16, 2025
Fun times! I'm just going to close this for now then.