Skip to content

[Due for payment 2025-08-19] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST in src/libs/CardMessageUtils.ts #66287

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/CardMessageUtils.ts
  • Onyx Key: ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST
  • Reference: Line 23: ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @NicMendonca

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @NicMendonca this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. DylanDylann commented on Jul 31, 2025

    @DylanDylann
    Contributor

    I and @ikevin127 Will work on this issue. @danieldoglas Could you help to assign us?

  7. 22 remaining items

  8. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@NicMendonca)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. kadiealexander commented on Aug 19, 2025

    @kadiealexander
    Contributor

    @danieldoglas I'd love your advice on handling the regression here, it's hard to make sense of what happened after.

  10. danieldoglas commented on Aug 20, 2025

    @danieldoglas
    Contributor

    @kadiealexander I think we can move forward with this one as a full payment. $250

  11. garrettmknight commented on Aug 21, 2025

    @garrettmknight
    Contributor

    $250 approved for @ikevin127

  12. melvin-bot commented on Aug 21, 2025

    @melvin-bot

    @NicMendonca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. melvin-bot commented on Aug 25, 2025

    @melvin-bot

    @NicMendonca Still overdue 6 days?! Let's take care of this!

  14. melvin-bot commented on Aug 27, 2025

    @melvin-bot

    @NicMendonca Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  15. kadiealexander commented on Aug 28, 2025

    @kadiealexander
    Contributor

    Payment summary here.

  16. quinthar commented on Aug 28, 2025

    @quinthar
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions