Skip to content

[Due for payment 2025-08-20] Remove Onyx.connect() for the key: ONYXKEYS.NVP_PRIORITY_MODE in src/libs/DebugUtils.ts #66301

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/DebugUtils.ts
  • Onyx Key: ONYXKEYS.NVP_PRIORITY_MODE
  • Reference: Line 91: ONYXKEYS.NVP_PRIORITY_MODE

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. shubham1206agra commented on Aug 4, 2025

    @shubham1206agra
    Contributor

    @tgolen Please assign me and @ikevin127 as C+

  8. 2 remaining items

  9. added and removed on Aug 11, 2025
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 13, 2025
  11. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PRIORITY_MODE` in `src/libs/DebugUtils.ts`[/-] [+][Due for payment 2025-08-20] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PRIORITY_MODE` in `src/libs/DebugUtils.ts`[/+] on Aug 13, 2025
  12. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.93-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-20. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    @ikevin127 / @shubham1206agra @kadiealexander The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. kadiealexander commented on Aug 20, 2025

    @kadiealexander
    Contributor

    Payment Summary

  16. garrettmknight commented on Aug 21, 2025

    @garrettmknight
    Contributor

    $250 approved for @ikevin127

  17. trjExpensify commented on Sep 1, 2025

    @trjExpensify
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions