Skip to content

[Due for payment 2026-08-18] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_TAGS in src/libs/ModifiedExpenseMessage.ts #66336

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @OfstadC this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. pasyukevich commented on Aug 14, 2025

    @pasyukevich
    Contributor

    I will be on vacation from this Friday, August 15, until August 30.

    @kubabutkiewicz will continue work here

  7. 143 remaining items

  8. parasharrajat commented on Aug 7, 2026

    @parasharrajat
    Member

    So there were 13 PRs where I reviewed closed ones as well. They were big and confusing, so we broke them into smaller ones. Thus, 10 new PRs. Can you suggest the payment for this @tgolen ?

  9. tgolen commented on Aug 7, 2026

    @tgolen
    ContributorAuthor

    Reopening for payment, then let me look at those PRs.

  10. reopened this on Aug 7, 2026
  11. tgolen commented on Aug 7, 2026

    @tgolen
    ContributorAuthor

    Small PRs:

    #86327 is kind of small, but it's balanced out by #83931 being on the large size, so I'm going to price them both at $250.

    That makes 7 issues @ $250 and 3 issues @ $125

    Total: $2,125

    @parasharrajat I was a little uncertain what you meant to do with the three closed PRs.

  12. parasharrajat commented on Aug 8, 2026

    @parasharrajat
    Member

    @tgolen Let's round off the total to 2250 to cover testing on these 2 closed PRs.

    No need for partial payment.

    Thanks.

  13. tgolen commented on Aug 10, 2026

    @tgolen
    ContributorAuthor

    OK, that sounds fine. Thanks!

    I approve a total of $2,250

  14. parasharrajat commented on Aug 10, 2026

    @parasharrajat
    Member

    @mallenexpensify Ready for summary.

  15. mallenexpensify commented on Aug 18, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @parasharrajat due $2250 via NewDot

    @tgolen for onyx.connect issues that are due payment, can you plz add the Awaiting Payment label? I'll be able to pay them quicker. Thx

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Aug 18, 2026
  17. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.POLICY_TAGS` in `src/libs/ModifiedExpenseMessage.ts`[/-] [+][Due for payment 2026-08-18] Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.POLICY_TAGS` in `src/libs/ModifiedExpenseMessage.ts`[/+] on Aug 18, 2026
  18. melvin-bot commented on Aug 18, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  19. garrettmknight commented on Sep 18, 2026

    @garrettmknight
    Contributor

    $2,250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.MonthlyKSv2Not a prioritySkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions