Skip to content

[Due for payment 2025-09-17] Remove Onyx.connect() for the key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT in src/libs/Network/enhanceParameters.ts #66358

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/Network/enhanceParameters.ts
  • Onyx Key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT
  • Reference: Line 12: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. removed their assignment
    on Jul 17, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. allgandalf commented on Aug 12, 2025

    @allgandalf
    Contributor

    @danieldoglas can you please assign me here with @shubham1206agra

  8. 8 remaining items

  9. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT` in `src/libs/Network/enhanceParameters.ts`[/-] [+][Due for payment 2025-09-17] Remove `Onyx.connect()` for the key: `ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT` in `src/libs/Network/enhanceParameters.ts`[/+] on Sep 10, 2025
  10. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-17. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Sep 10, 2025

    @melvin-bot

    @shubham1206agra @VictoriaExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. allgandalf commented on Sep 11, 2025

    @allgandalf
    Contributor

    @allgandalf does not require payment (Contractor)

    Summary is wrong, i require payment via upwork

  14. melvin-bot commented on Sep 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@VictoriaExpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. VictoriaExpensify commented on Sep 18, 2025

    @VictoriaExpensify
    Contributor

    Payment summary:
    C: @allgandalf - offer sent via Upwork. Please accept so I can make payment
    C+: @shubham1206agra owed $250 via NewDot

  16. allgandalf commented on Sep 18, 2025

    @allgandalf
    Contributor

    I accepted, thanks!

  17. VictoriaExpensify commented on Sep 19, 2025

    @VictoriaExpensify
    Contributor

    Updated Payment summary:

    C: @allgandalf - Paid $250 via Upwork
    C+: @shubham1206agra owed $250 via NewDot

    Thanks all!

  18. twisterdotcom commented on Sep 26, 2025

    @twisterdotcom
    Contributor

    @shubham1206agra has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-5d58-a10c-a59c-3e73ce6d71b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions