Skip to content

[$250] [Due for payment 2025-09-17] Remove Onyx.connect() for the key: ONYXKEYS.ACCOUNT in src/libs/Network/enhanceParameters.ts #66359

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021967578931407121580
  • Upwork Job ID: 1967578931407121580
  • Last Price Increase: 2025-09-15

Activity

  1. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. allgandalf commented on Aug 12, 2025

    @allgandalf
    Contributor

    @danieldoglas can you please assign me here with @shubham1206agra

  7. 18 remaining items

  8. added and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 15, 2025
  9. laurenreidexpensify commented on Sep 15, 2025

    @laurenreidexpensify
    Contributor

    @allgandalf offer sent in upwork 👍

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 15, 2025
  11. allgandalf commented on Sep 17, 2025

    @allgandalf
    Contributor

    Offer accepted

  12. laurenreidexpensify commented on Sep 19, 2025

    @laurenreidexpensify
    Contributor

    Payment Summary

  13. twisterdotcom commented on Sep 26, 2025

    @twisterdotcom
    Contributor

    @shubham1206agra has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-6f15-a090-8005-dd4f029beb81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions