Skip to content

[Due for payment 2026-03-16] Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/OptionsListUtils.ts #66376

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. zanyrenney commented on Aug 18, 2025

    @zanyrenney
    Contributor

    Not overdue, this will be worked on when a contributor is assigned according to the correct priority.

  7. 100 remaining items

  8. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.PERSONAL_DETAILS_LIST` in `src/libs/OptionsListUtils.ts`[/-] [+][Due for payment 2026-03-16] Remove `Onyx.connect()` for the key: `ONYXKEYS.PERSONAL_DETAILS_LIST` in `src/libs/OptionsListUtils.ts`[/+] on Mar 9, 2026
  9. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-16. 🎊

    For reference, here are some details about the assignees on this issue:

    • @dukenv0307 requires payment through NewDot Manual Requests
    • @DylanDylann requires payment through NewDot Manual Requests
  11. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    @dukenv0307 / @DylanDylann @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. sonialiap commented on Mar 11, 2026

    @sonialiap
    Contributor

    @dukenv0307 was that the last PR?

  13. dukenv0307 commented on Mar 11, 2026

    @dukenv0307
    Contributor
  14. tgolen commented on Mar 11, 2026

    @tgolen
    ContributorAuthor

    @sonialiap I looked at all those PRs and it's fine to pay $250 for each one. That makes this issue $3000

  15. sonialiap commented on Mar 13, 2026

    @sonialiap
    Contributor

    Payment summary:
    @dukenv0307 $3000 please request through NewDot
    @DylanDylann $3000 please request through NewDot

  16. JmillsExpensify commented on Mar 18, 2026

    @JmillsExpensify
    Contributor

    $3,000 approved for @DylanDylann

  17. quinthar commented on Mar 18, 2026

    @quinthar
    Contributor

    Approved $3000 to @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions