Skip to content

[Partial Payment x2] Remove Onyx.connect() for the key: ONYXKEYS.ARE_TRANSLATIONS_LOADING in src/libs/PersonalDetailsUtils.ts #66392

Open

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @truph01

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @sakluger this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. 245 remaining items

  8. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Oct 27, 2026
  9. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  10. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  11. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @shubham1206agra Still overdue 6 days?! Let's take care of this!

  12. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    @shubham1206agra 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  13. added and removed on Nov 7, 2026
  14. truph01 commented on Nov 16, 2026

    @truph01
    Contributor

    @tgolen If possible, I can take over this one since Shubham1206agra is moving to BEC team

  15. shubham1206agra commented on Nov 16, 2026

    @shubham1206agra
    Contributor

    @truph01 All yours

  16. tgolen commented on Nov 16, 2026

    @tgolen
    ContributorAuthor

    Sounds good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.Not a prioritySkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions