Skip to content

[Due for payment 2026-07-29] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/ReportActionsUtils.ts #66406

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. dylanexpensify commented on Aug 12, 2025

    @dylanexpensify
    Contributor

    In progress.

  7. 74 remaining items

  8. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

  10. shubham1206agra commented on Jul 30, 2026

    @shubham1206agra
    Contributor

    Waiting for payment #66406 (comment)

  11. mallenexpensify commented on Jul 30, 2026

    @mallenexpensify
    Contributor

    @danieldoglas 👀 on the above to confirm how much is owed, thx

  12. danieldoglas commented on Aug 3, 2026

    @danieldoglas
    Contributor

    I think $250 each is fine. We had 2 small ones, but 2 big ones, so I think they balance it out. @mallenexpensify

  13. mallenexpensify commented on Aug 4, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @shubham1206agra due $1000 via NewDot
    Contributor+: @DylanDylann due $1000 via NewDot

  14. JmillsExpensify commented on Aug 10, 2026

    @JmillsExpensify
    Contributor

    $1,000 approved for @shubham1206agra

  15. quinthar commented on Sep 27, 2026

    @quinthar
    Contributor

    Approved $1000 to @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions