Skip to content

[Partial payment] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/ReportUtils.ts #66412

Open

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @maddylewis this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 1, 2025
  8. 295 remaining items

  9. melvin-bot commented on Sep 21, 2026

    @melvin-bot

    @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. DylanDylann commented on Sep 23, 2026

    @DylanDylann
    Contributor

    not overdue

  11. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

  12. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @DylanDylann 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  13. thelullabyy commented on Oct 5, 2026

    @thelullabyy
    Contributor

    Working on part 6...

  14. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @tgolen, @pecanoro, @mollfpr, @DylanDylann, @thelullabyy eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.MonthlyKSv2ReviewingHas a PR in reviewSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions