Skip to content

Remove Onyx.connect() for the key: ONYXKEYS.ARE_TRANSLATIONS_LOADING in src/libs/ReportUtils.ts #66430

Open

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/ReportUtils.ts
  • Onyx Key: ONYXKEYS.ARE_TRANSLATIONS_LOADING
  • Reference: Line 1122: ONYXKEYS.ARE_TRANSLATIONS_LOADING

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. self-assigned this
    on Jul 16, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  3. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Jul 16, 2025
  6. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @tgolen @clarajones-expensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. clarajones-expensify commented on Aug 18, 2025

    @clarajones-expensify
    Contributor

    not overdue

  8. 152 remaining items

  9. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    @shubham1206agra Still overdue 6 days?! Let's take care of this!

  10. melvin-bot commented on Oct 30, 2026

    @melvin-bot

    @shubham1206agra 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  11. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @shubham1206agra 12 days overdue. Walking. Toward. The. Light...

  12. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @shubham1206agra 12 days overdue. Walking. Toward. The. Light...

  13. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @shubham1206agra 12 days overdue now... This issue's end is nigh!

  14. melvin-bot commented on Nov 6, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @tgolen, @luacmartins, @mallenexpensify, @mountiny, @shubham1206agra, @daledah eroding to Weekly issue.

  15. truph01 commented on Nov 16, 2026

    @truph01
    Contributor

    @tgolen If possible. I can take over this one since shubham1206agra is moving to BEC team

  16. situchan commented on Nov 16, 2026

    @situchan
    Contributor

    I can help as well

  17. shubham1206agra commented on Nov 16, 2026

    @shubham1206agra
    Contributor

    @daledah What's the progress here?

  18. daledah commented on Nov 16, 2026

    @daledah
    Contributor

    @shubham1206agra this one is on hold waiting for #98439

    Everything else for this key is done. The only remaining consumer of the hiddenTranslation module cache is 3 getDisplayNameForParticipant calls, all inside the optimistic report-action builders whose text/html #98439 removes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.Not a prioritySkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions