Skip to content

[Due for payment 2026-06-23] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/SubscriptionUtils.ts #66442

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. 176 remaining items

  7. shubham1206agra commented on Jun 17, 2026

    @shubham1206agra
    Contributor

    @tgolen Which 3 cause the payout is pretty weird here for @hungvu193?

  8. tgolen commented on Jun 17, 2026

    @tgolen
    ContributorAuthor

    #87997
    #87995
    #87660
    #87510

    The first and last one are kind of on the edge, so I only considered one of them to be small.

  9. shubham1206agra commented on Jun 17, 2026

    @shubham1206agra
    Contributor

    @mallenexpensify So payout are as follows

    @shubham1206agra - $2125
    @hungvu193 - $1875
    @marufsharifi - $250

  10. mallenexpensify commented on Jun 22, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @marufsharifi paid $250 via Upwork
    Contributor+: @shubham1206agra due $2125 via NewDot
    Contributor+: @hungvu193 due $1875 via NewDot

    @marufsharifi can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022069071781477236402

  11. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  12. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

  13. marufsharifi commented on Jun 23, 2026

    @marufsharifi

    @mallenexpensify, I've accepted the offer. thanks.

  14. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  15. mallenexpensify commented on Jun 25, 2026

    @mallenexpensify
    Contributor

    @marufsharifi paid, summary updated above. Thx.

    Think/hope we're cool to close...

  16. JmillsExpensify commented on Jun 28, 2026

    @JmillsExpensify
    Contributor

    $1,875 approved for @hungvu193

  17. JmillsExpensify commented on Jul 12, 2026

    @JmillsExpensify
    Contributor

    $2,125 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions