Skip to content

[Due for payment 2026-04-28] Remove Onyx.connect() for the key: ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED in src/libs/SubscriptionUtils.ts #66443

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. dylanexpensify commented on Aug 12, 2025

    @dylanexpensify
    Contributor

    In progress.

  7. 90 remaining items

  8. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    @shubham1206agra / @dukenv0307 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

  10. shubham1206agra commented on Apr 22, 2026

    @shubham1206agra
    Contributor

    Waiting for payment on 28th

  11. changed the title [-][Due for payment 2026-04-28] [Due for payment 2026-04-23] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED` in `src/libs/SubscriptionUtils.ts`[/-] [+][Due for payment 2026-04-28] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED` in `src/libs/SubscriptionUtils.ts`[/+] on Apr 23, 2026
  12. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  13. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

  14. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. mallenexpensify commented on Apr 29, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @shubham1206agra due $2500 via NewDot
    Contributor+: @dukenv0307 due $2500 via NewDot

    Think/hope we're good to close!

  16. JmillsExpensify commented on May 1, 2026

    @JmillsExpensify
    Contributor

    $2,500 approved for @shubham1206agra

  17. quinthar commented on May 6, 2026

    @quinthar
    Contributor

    Approved $2500 to @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions