Skip to content

Remove Onyx.connect() for the key: ONYXKEYS.NVP_PRIVATE_BILLING_DISPUTE_PENDING in src/libs/SubscriptionUtils.ts #66445

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/SubscriptionUtils.ts
  • Onyx Key: ONYXKEYS.NVP_PRIVATE_BILLING_DISPUTE_PENDING
  • Reference: Line 78: ONYXKEYS.NVP_PRIVATE_BILLING_DISPUTE_PENDING

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @danieldoglas @abekkala this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. 3 remaining items

  7. allgandalf commented on Oct 6, 2025

    @allgandalf
    Contributor

    not overdue

  8. allgandalf commented on Nov 3, 2025

    @allgandalf
    Contributor

    PR merged

  9. allgandalf commented on Nov 10, 2025

    @allgandalf
    Contributor

    Automation failed here, this one is ready for payment, no checklist required(see here)

    Image
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 10, 2025
  11. abekkala commented on Nov 10, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR NOV 10:

    Thank you! 🎉

  12. quinthar commented on Nov 19, 2025

    @quinthar
    Contributor

    Approved $250 to @allgandalf

  13. garrettmknight commented on Dec 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions