Skip to content

[Due for payment 2025-10-31] Remove Onyx.connect() for the key: ONYXKEYS.NVP_PRIVATE_FIRST_POLICY_CREATED_DATE in src/libs/SubscriptionUtils.ts #66447

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/SubscriptionUtils.ts
  • Onyx Key: ONYXKEYS.NVP_PRIVATE_FIRST_POLICY_CREATED_DATE
  • Reference: Line 90: ONYXKEYS.NVP_PRIVATE_FIRST_POLICY_CREATED_DATE

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2025
  2. tgolen commented on Jul 16, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 16, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added and removed on Jul 16, 2025
  5. melvin-bot commented on Jul 30, 2025

    @melvin-bot

    @johncschuster @danieldoglas this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  6. 10 remaining items

  7. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PRIVATE_FIRST_POLICY_CREATED_DATE` in `src/libs/SubscriptionUtils.ts`[/-] [+][Due for payment 2025-10-31] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PRIVATE_FIRST_POLICY_CREATED_DATE` in `src/libs/SubscriptionUtils.ts`[/+] on Oct 24, 2025
  8. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.37-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-31. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. allgandalf commented on Oct 28, 2025

    @allgandalf
    Contributor

    @allgandalf does not require payment (Contractor)

    Summary is wrong i require payment for this job via ND

  12. johncschuster commented on Oct 28, 2025

    @johncschuster
    Contributor

    Payment Summary

    Contributor: @allgandalf due $250 via NewDot
    Contributor+: @shubham1206agra due $250 via NewDot

  13. allgandalf commented on Oct 31, 2025

    @allgandalf
    Contributor

    No checklist needed, good to close:

    #66447 (comment)

  14. quinthar commented on Nov 19, 2025

    @quinthar
    Contributor

    Approve $250 to @allgandalf

  15. garrettmknight commented on Dec 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions