Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.82-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://docs.google.com/spreadsheets/d/1nPID07oiJkVDfW0GDmVYKrbmvse7V_3BnW-Rmyyr_Hs/edit?gid=319833773#gid=319833773&range=D19
Email or phone of affected tester (no customers): ibellicotest+1341@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 10 / Chrome
App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.0
- Open the staging.new.epensify.com
- Open any workspace chat.
- Submit a manual expense to it.
- Turn off internet connection.
- Long tap and delete the expense.
- Return to "Inbox"
- Create a new expense and submit it to Self DM.
- Open Self DM.
- Open the just created expense.
- Tap on the report field, and select the report of the deleted expense.
- Once the expense was moved, turn on internet connection.
- Note that an "It´s not here" page appears.
- Tap on the arrow on the top left corner.
- Note that you land on an empty report, where only the header displays the expense amount.
- Tap on the arrow on the top left corner again.
- Note that you land on Self DM, and the last created expense, is displayed again, but now, system message is displayed above it.
Expected Result:
When recovering internet connection after moving a track expense to a report of a deleted expense, the moved expense should remain on report, while the deleted one should disappear automatically.
Actual Result:
When recovering internet connection after moving a track expense to a report of a deleted expense, an "It´s not here" page appears and when returning from that page, user lands on an empty report, where only the header displays the expense amount. Also, when returning to Self DM, expense reappears, but Concierge system message now appears above the expense.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
bug.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021945907107487983677
- Upwork Job ID: 1945907107487983677
- Last Price Increase: 2025-07-17
- Automatic offers:
- FitseTLT | Contributor | 108126436
Issue Owner
Current Issue Owner: @FitseTLTMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Jul 17, 2025
Triggered auto assignment to @clarajones-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Jul 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report - "It´s not here" page when moving track expense to report of deleted expense offline
What is the root cause of that problem?
We are not filtering out pending delete reports here
App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx
Lines 81 to 91 in 48a96b0
so moving the expense to a deleted expense will fail in BE
What changes do you think we should make in order to solve the problem?
We should not allow moving to a pending delete reports so we should filter out or disable report options that are pending delete.
Currently, when all the expenses in the expense report is deleted (
shouldDeleteIOUReport) we add pending delete onpendingfields.previewon the iou reportApp/src/libs/actions/IOU.ts
Lines 8125 to 8127 in 48a96b0
So we can either utilize it or add pendingAction delete on the iou report here
App/src/libs/actions/IOU.ts
Lines 8123 to 8125 in 48a96b0
We can add
and also revert on failureData
Then we will add the whatever pending field we use above here to use the field in the page
App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx
Line 37 in 48a96b0
We can apply the filtering logic to
getOutstandingReportsForUserfor more generic solution so that report field menu will not be enabled when all the expense reports are pending delete ones as we use it to check if there are enough available reports to chose from.or if we want we can disable the option
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
If need we can add a test for getOutstandingReportsForUser to assert it fitlers pending delete reports.
What alternative solutions did you explore? (Optional)
[-]Report - "It´s not here" page when moving track expense to report of deleted expense offline[/-][+][$250] Report - "It´s not here" page when moving track expense to report of deleted expense offline[/+]melvin-bot commentedon Jul 17, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021945907107487983677
melvin-bot commentedon Jul 17, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)ZhenjaHorbach commentedon Jul 21, 2025
@FitseTLT
Thanks for your proposal
This proposal makes sense to me !
🎀👀🎀 C+
melvin-bot commentedon Jul 21, 2025
Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
1 remaining item
melvin-bot commentedon Jul 21, 2025
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
FitseTLT commentedon Aug 8, 2025
@clarajones-expensify Payment overdue based on #66980 (comment) Thx
ZhenjaHorbach commentedon Aug 8, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Unfortunately, I did not find a suitable PR
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
clarajones-expensify commentedon Aug 8, 2025
Payment Summary
Contributor: @FitseTLT paid $250 via Upwork job
Contributor+: @ZhenjaHorbach due $250 via NewDot
ZhenjaHorbach commentedon Aug 8, 2025
Requested in ND !
isabelastisser commentedon Aug 8, 2025
$250 approved in ND.