Skip to content

[Due for payment 2025-08-13] Fix canBeMissing alert for for key transactionsDraft_1 #66879

Closed

Description

@iwiznia

Keys: transactionsDraft_1
OG issue: https://github.com/Expensify/Expensify/issues/509588
Suspect introduction in #61760 from #65032 (comment)

@SzymczakJ you are the author of that PR, can you take a look at this please?

Activity

  1. self-assigned this
    on Jul 22, 2025
  2. SzymczakJ commented on Jul 22, 2025

    @SzymczakJ
    Contributor

    I cannot reproduce it, do you have the reproduction steps?
    Or should I just blindly set canBeMissing to false here?

  3. iwiznia commented on Jul 22, 2025

    @iwiznia
    ContributorAuthor

    I cannot reproduce it, do you have the reproduction steps?

    No, it's just a log line. You went through those flows and can't see it?

    Or should I just blindly set canBeMissing to false here?

    No, do not blindly do it. Is this flow expecting to always have a draftTransaction in that case? What should be creating/loading it? Does the code work if the data is not there?

  4. SzymczakJ commented on Jul 22, 2025

    @SzymczakJ
    Contributor

    I went through the flows a couple of times and cannot reproduce it, that's why I asked for the repro steps.
    I will dig deeper tomorrow 🫡

  5. SzymczakJ commented on Jul 23, 2025

    @SzymczakJ
    Contributor

    I managed to reproduce it. I think it is safe to set canBeMissing to true:

    1. IOURequestStepAmount uses transactionDraft only for computing currency, when this is edit flow. In that flow the transactionDraft is always there and canBeMissing alert is not shown. The alert is shown in creation flow in which transactionDraft is not needed because we use normal transaction so in that case it can be missing.
    2. Even when transactionDraft is missing we have fallback logic that uses normal transaction, so nothing gets broken.
    3. Every other usage of ONYXKEYS.COLLECTION.TRANSACTION_DRAFT key is set to canBeMissing to true
  6. SzymczakJ commented on Aug 1, 2025

    @SzymczakJ
    Contributor

    FYI I'll be OOO for the whole next week.

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 6, 2025
  8. 7 remaining items

  9. melvin-bot commented on Aug 15, 2025

    @melvin-bot

    @iwiznia Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. melvin-bot commented on Aug 19, 2025

    @melvin-bot

    @iwiznia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  11. rojiphil commented on Aug 20, 2025

    @rojiphil
    Contributor

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

    Please assign me here for payment summary as I was the C++ reviewer here. Thanks.

  12. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 20, 2025
  13. melvin-bot commented on Aug 20, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  14. trjExpensify commented on Aug 20, 2025

    @trjExpensify
    Contributor

    Can we get the checklist please, @rojiphil? Thanks!

  15. rojiphil commented on Aug 21, 2025

    @rojiphil
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Clear the Onyx data. Alternatively, uninstall and install the application again.

    Test:

    Note: Tests are applicable for native mobile versions only

    1. Navigate to a workspace chat.
    2. Create a manual expense
    3. Verify that no alerts are displayed for a missing draft transaction.

    Do we agree 👍 or 👎

  16. rojiphil commented on Aug 21, 2025

    @rojiphil
    Contributor

    @trjExpensify BZ Checklist done. Thanks.

  17. trjExpensify commented on Aug 22, 2025

    @trjExpensify
    Contributor

    I don't think we add console error alerts, and the flow of creating an expense is covered.

    Payment summary as follows:

    Go ahead and request! Closing.

  18. rojiphil commented on Nov 7, 2025

    @rojiphil
    Contributor

    payment received

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions