You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-13] Fix canBeMissing alert for for key transactionsDraft_1 #66879
I cannot reproduce it, do you have the reproduction steps?
No, it's just a log line. You went through those flows and can't see it?
Or should I just blindly set canBeMissing to false here?
No, do not blindly do it. Is this flow expecting to always have a draftTransaction in that case? What should be creating/loading it? Does the code work if the data is not there?
I managed to reproduce it. I think it is safe to set canBeMissing to true:
IOURequestStepAmount uses transactionDraft only for computing currency, when this is edit flow. In that flow the transactionDraft is always there and canBeMissing alert is not shown. The alert is shown in creation flow in which transactionDraft is not needed because we use normal transaction so in that case it can be missing.
Even when transactionDraft is missing we have fallback logic that uses normal transaction, so nothing gets broken.
Every other usage of ONYXKEYS.COLLECTION.TRANSACTION_DRAFT key is set to canBeMissing to true
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Please assign me here for payment summary as I was the C++ reviewer here. Thanks.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Clear the Onyx data. Alternatively, uninstall and install the application again.
Test:
Note: Tests are applicable for native mobile versions only
Navigate to a workspace chat.
Create a manual expense
Verify that no alerts are displayed for a missing draft transaction.
Activity
SzymczakJ commentedon Jul 22, 2025
I cannot reproduce it, do you have the reproduction steps?
Or should I just blindly set
canBeMissingtofalsehere?iwiznia commentedon Jul 22, 2025
No, it's just a log line. You went through those flows and can't see it?
No, do not blindly do it. Is this flow expecting to always have a
draftTransactionin that case? What should be creating/loading it? Does the code work if the data is not there?SzymczakJ commentedon Jul 22, 2025
I went through the flows a couple of times and cannot reproduce it, that's why I asked for the repro steps.
I will dig deeper tomorrow 🫡
SzymczakJ commentedon Jul 23, 2025
I managed to reproduce it. I think it is safe to set
canBeMissingtotrue:ONYXKEYS.COLLECTION.TRANSACTION_DRAFTkey is set to canBeMissing to trueSzymczakJ commentedon Aug 1, 2025
FYI I'll be OOO for the whole next week.
7 remaining items
melvin-bot commentedon Aug 15, 2025
@iwiznia Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Aug 19, 2025
@iwiznia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
rojiphil commentedon Aug 20, 2025
Please assign me here for payment summary as I was the C++ reviewer here. Thanks.
melvin-bot commentedon Aug 20, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Aug 20, 2025
Can we get the checklist please, @rojiphil? Thanks!
rojiphil commentedon Aug 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Clear the Onyx data. Alternatively, uninstall and install the application again.
Test:
Note: Tests are applicable for native mobile versions only
Do we agree 👍 or 👎
rojiphil commentedon Aug 21, 2025
@trjExpensify BZ Checklist done. Thanks.
trjExpensify commentedon Aug 22, 2025
I don't think we add console error alerts, and the flow of creating an expense is covered.
Payment summary as follows:
Go ahead and request! Closing.
rojiphil commentedon Nov 7, 2025
payment received