Skip to content

[HOLD for payment 2022-01-11] IOU - Cursor is set to pointer in IOU preview - Reported by: @Tushu17 #6693

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login
  2. Request money from account B
  3. Click on amount on top to open details window
  4. Hover over amount and user details

Expected Result:

User should not see pointer as this section is not clickable

Actual Result:

User can see pointer in IOU details but there is no action occurring hen clicking on it

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.18-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify.bug.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638989787379500

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Dec 10, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. MelvinBot commented on Dec 10, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Dec 10, 2021
  4. PrashantMangukiya commented on Dec 10, 2021

    @PrashantMangukiya
    Contributor

    Proposed Solution: (If considered as external)

    Here is the problem: There is a styles.iouPreviewBox at line 106 this style consist cursor as pointer, So it shows pointer cursor either `props.onPreviewPressed' passed or not.

    <TouchableWithoutFeedback onPress={props.onPreviewPressed}>
    <View style={styles.iouPreviewBox}>
    {reportIsLoading
    ? <ActivityIndicator style={styles.iouPreviewBoxLoading} color={themeColors.text} />
    : (


    Solution1: This is simple solution.
    We have to set cursor style to default if props.onPreviewPressed not passed. So we have to change line 106 within IOUPreview.js as under.

      <View style={[styles.iouPreviewBox, !_.isFunction(props.onPreviewPressed) && styles.cursorDefault]}>

    Also add cursorDefault style within styles.js as under:

    cursorDefault: {
        cursor: 'default',
    },
    

    Solution 2: This is slightly complex solution.
    We can conditionally render TouchableWithoutFeedback component as shown under. i.e. If props.onPreviewPressed passed then we will wrap TouchableWithoutFeedback component, otherwise not.

    So implementation will be as under. i.e. Prepare Wrapper and replace <TouchableWithoutFeedback onPress={props.onPreviewPressed}> with <Wrapper onPress={props.onPreviewPressed}>

    // Add this wrapper
    const Wrapper = ({children, onPress}) => {
        if (onPress) {
            return (
                <TouchableWithoutFeedback onPress={onPress}>
                    {children}
                </TouchableWithoutFeedback>
            );
        }
        return children;
    };
    
    // Old code 
    <TouchableWithoutFeedback onPress={props.onPreviewPressed}>
      <View style={styles.iouPreviewBox}>
        ....
       </View>
    </TouchableWithoutFeedback>
    
    // Use this wrapper
    <Wrapper onPress={props.onPreviewPressed}>
      <View style={[styles.iouPreviewBox, !_.isFunction(props.onPreviewPressed) && styles.cursorDefault]}>
       ...
      </View>
    </Wrapper>

    Also add cursorDefault style within styles.js as under:

    cursorDefault: {
        cursor: 'default',
    },
    

    Below is the screen record with this implementation, it gives same result either we use solution1 or solution2

    ScreenRecording6693.mov
  5. removed their assignment
    on Dec 12, 2021
  6. changed the title [-]IOU - Cursor is set to pointer in IOU preview - Reported by: @Tushu[/-] [+]IOU - Cursor is set to pointer in IOU preview - Reported by: @Tushu17[/+] on Dec 14, 2021
  7. parasharrajat commented on Dec 15, 2021

    @parasharrajat
    Member

    Does not hurt in my opinion.

  8. added
    ImprovementItem broken or needs improvement.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 15, 2021
  9. 31 remaining items

  10. mallenexpensify commented on Dec 29, 2021

    @mallenexpensify
    Contributor

    PR is on staging, should hit production soon...

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 4, 2022
  12. botify commented on Jan 4, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-11. 🎊

  13. changed the title [-]IOU - Cursor is set to pointer in IOU preview - Reported by: @Tushu17[/-] [+][HOLD for payment 2022-01-11] IOU - Cursor is set to pointer in IOU preview - Reported by: @Tushu17[/+] on Jan 4, 2022
  14. mallenexpensify commented on Jan 12, 2022

    @mallenexpensify
    Contributor

    Paid @Tushu17 for reporting and @PrashantMangukiya for the fix
    @parasharrajat can you apply here for C+ https://www.upwork.com/jobs/~0122afc050e1e1d5fd

  15. parasharrajat commented on Jan 13, 2022

    @parasharrajat
    Member
  16. mallenexpensify commented on Jan 13, 2022

    @mallenexpensify
    Contributor

    Hired you @parasharrajat , let me know when you've accepted offer

  17. parasharrajat commented on Jan 13, 2022

    @parasharrajat
    Member

    @mallenexpensify Accepted it.

  18. mallenexpensify commented on Jan 13, 2022

    @mallenexpensify
    Contributor

    Can you double check @parasharrajat ? I'm not seeing the normal option to pay

  19. mallenexpensify commented on Jan 13, 2022

    @mallenexpensify
    Contributor

    Paid @parasharrajat in Upwork (I think/hope). There was a glitch where I wasn't able to access the payment screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions