Skip to content

[Due for payment 2025-08-13] [$250] Composer - Edit compose box is not auto-focused when editing a message in report page #66988

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65229
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause Internal Team
Device used: Android
App Component: Other

Action Performed:

Precondition: User should have. a workspace

  1. Go to Reports
  2. Tap FAB > Create Report > Send a message
  3. When keyboard is up, long press the message > Tap Edit comment

Expected Result:

Editing Composer should be focused

Actual Result:

Main composer is focused instead of editing composer

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021948409177921856446
  • Upwork Job ID: 1948409177921856446
  • Last Price Increase: 2025-07-24
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 23, 2025
  2. melvin-bot commented on Jul 23, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Eskalifer1 commented on Jul 23, 2025

    @Eskalifer1
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Composer - Edit compose box is not auto-focused when editing a message in report page

    What is the root cause of that problem?

    The problem is that we use FlatList instead of InvertedFlatList, as in the case of a simple chat. FlatList itself has a removeClippedSubviews prop, which removes an element from the virtual tree to improve optimization.

    What changes do you think we should make in order to solve the problem?

    Since this prop breaks a certain logic, we pass it as false by default for InvertedFlatList

    removeClippedSubviews={false}

    Similarly, we can pass this prop as false for this component:

    <FlatList
    initialNumToRender={INITIAL_NUM_TO_RENDER}
    accessibilityLabel={translate('sidebarScreen.listOfChatMessages')}
    testID="money-request-report-actions-list"
    style={styles.overscrollBehaviorContain}
    data={visibleReportActions}
    renderItem={renderItem}
    keyExtractor={keyExtractor}
    onLayout={recordTimeToMeasureItemLayout}
    onEndReached={onEndReached}
    onEndReachedThreshold={0.75}
    onStartReached={onStartReached}
    onStartReachedThreshold={0.75}
    ListHeaderComponent={
    <>
    <MoneyRequestViewReportFields
    report={report}
    policy={policy}
    />
    <MoneyRequestReportTransactionList
    report={report}
    transactions={transactions}
    newTransactions={newTransactions}
    reportActions={reportActions}
    hasComments={reportHasComments}
    isLoadingInitialReportActions={showReportActionsLoadingState}
    scrollToNewTransaction={scrollToNewTransaction}
    />
    </>
    }
    keyboardShouldPersistTaps="handled"
    onScroll={trackVerticalScrolling}
    contentContainerStyle={[shouldUseNarrowLayout ? styles.pt4 : styles.pt2]}
    ref={reportScrollManager.ref}
    ListEmptyComponent={!isOffline && showReportActionsLoadingState ? <ReportActionsListLoadingSkeleton /> : undefined} // This skeleton component is only used for loading state, the empty state is handled by SearchMoneyRequestReportEmptyState
    />

    removeClippedSubviews={false}

    We can only pass this for Android native, if necessary.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. changed the title [-]Composer - Edit compose box is not auto-focused when editing a message in report page[/-] [+][$250] Composer - Edit compose box is not auto-focused when editing a message in report page[/+] on Jul 24, 2025
  5. melvin-bot commented on Jul 24, 2025

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 24, 2025
  7. melvin-bot commented on Jul 24, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  8. dukenv0307 commented on Jul 25, 2025

    @dukenv0307
    Contributor

    @Eskalifer1's proposal looks good to me

    🎀👀🎀 C+ reviewed

  9. melvin-bot commented on Jul 25, 2025

    @melvin-bot

    Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  10. 37 remaining items

  11. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@VictoriaExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1948409177921856446/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. Eskalifer1 commented on Aug 15, 2025

    @Eskalifer1
    Contributor

    Gentle bump on payment here. Thank you ^)

  13. Eskalifer1 commented on Aug 19, 2025

    @Eskalifer1
    Contributor

    Gentle bump on payment here. Thank you :)

  14. laurenreidexpensify commented on Aug 20, 2025

    @laurenreidexpensify
    Contributor

    @dukenv0307 bump on checklist please

  15. laurenreidexpensify commented on Aug 20, 2025

    @laurenreidexpensify
    Contributor

    Payment Summary

  16. dukenv0307 commented on Aug 20, 2025

    @dukenv0307
    Contributor

    @laurenreidexpensify I completed the checklists here

  17. garrettmknight commented on Aug 20, 2025

    @garrettmknight
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions