You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-13] [$250] Composer - Edit compose box is not auto-focused when editing a message in report page #66988
Version Number: v9.1.85-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#65229 Email or phone of affected tester (no customers):expensify416+da2@gmail.com Issue reported by: Applause Internal Team Device used: Android App Component: Other
Action Performed:
Precondition: User should have. a workspace
Go to Reports
Tap FAB > Create Report > Send a message
When keyboard is up, long press the message > Tap Edit comment
Expected Result:
Editing Composer should be focused
Actual Result:
Main composer is focused instead of editing composer
Please re-state the problem that we are trying to solve in this issue.
Composer - Edit compose box is not auto-focused when editing a message in report page
What is the root cause of that problem?
The problem is that we use FlatList instead of InvertedFlatList, as in the case of a simple chat. FlatList itself has a removeClippedSubviews prop, which removes an element from the virtual tree to improve optimization.
What changes do you think we should make in order to solve the problem?
Since this prop breaks a certain logic, we pass it as false by default for InvertedFlatList
ListEmptyComponent={!isOffline&&showReportActionsLoadingState ? <ReportActionsListLoadingSkeleton/> : undefined}// This skeleton component is only used for loading state, the empty state is handled by SearchMoneyRequestReportEmptyState
/>
removeClippedSubviews={false}
We can only pass this for Android native, if necessary.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Composer - Edit compose box is not auto-focused when editing a message in report page[/-][+][$250] Composer - Edit compose box is not auto-focused when editing a message in report page[/+]on Jul 24, 2025
Activity
melvin-bot commentedon Jul 23, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Eskalifer1 commentedon Jul 23, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Composer - Edit compose box is not auto-focused when editing a message in report page
What is the root cause of that problem?
The problem is that we use FlatList instead of InvertedFlatList, as in the case of a simple chat. FlatList itself has a removeClippedSubviews prop, which removes an element from the virtual tree to improve optimization.
What changes do you think we should make in order to solve the problem?
Since this prop breaks a certain logic, we pass it as false by default for InvertedFlatList
App/src/components/InvertedFlatList/index.native.tsx
Line 20 in 57f0196
Similarly, we can pass this prop as false for this component:
App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
Lines 636 to 671 in 57f0196
We can only pass this for Android native, if necessary.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Composer - Edit compose box is not auto-focused when editing a message in report page[/-][+][$250] Composer - Edit compose box is not auto-focused when editing a message in report page[/+]melvin-bot commentedon Jul 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021948409177921856446
melvin-bot commentedon Jul 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)dukenv0307 commentedon Jul 25, 2025
@Eskalifer1's proposal looks good to me
🎀👀🎀 C+ reviewed
melvin-bot commentedon Jul 25, 2025
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
37 remaining items
melvin-bot commentedon Aug 13, 2025
Payment Summary
Upwork Job
BugZero Checklist (@VictoriaExpensify)
Eskalifer1 commentedon Aug 15, 2025
Gentle bump on payment here. Thank you ^)
Eskalifer1 commentedon Aug 19, 2025
Gentle bump on payment here. Thank you :)
laurenreidexpensify commentedon Aug 20, 2025
@dukenv0307 bump on checklist please
laurenreidexpensify commentedon Aug 20, 2025
Payment Summary
dukenv0307 commentedon Aug 20, 2025
@laurenreidexpensify I completed the checklists here
garrettmknight commentedon Aug 20, 2025
$250 approved for @dukenv0307