[Due for payment 2025-09-19] [Due for payment 2025-08-15] [$250] [EX-50] No "What's your name?" modal if Manage my teams selected

@bfitzexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.85-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2148171/test-runs/TR-167/39855672/800111115?sort=%2Bidentifier
Email or phone of affected tester (no customers): qaooxx+304@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Sign up with a new email address
Skip the “Work email” step
Select the intent: “Manage my team’s expenses”
Proceed with onboarding process

Expected Result:

User should be prompted to input First and Last name

Actual Result:

User is not prompted to input First and Last name

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

Bug6896749_1753300936974.1_01_PM_2025-07-23.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021949891158079943967
Upwork Job ID: 1949891158079943967
Last Price Increase: 2025-07-28
Automatic offers:

samranahm | Contributor | 108220121

Issue Owner

Current Issue Owner: @bfitzexpensify

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No "What's your name?" modal if Manage my teams selected

What is the root cause of that problem?

here

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 191 to 201 in b04e219

    
           const handleContinue = useCallback(() => { 
        
               if (userReportedIntegration === undefined) { 
        
                   setError(translate('onboarding.errorSelection')); 
        
                   return; 
        
               } 
        
               setOnboardingUserReportedIntegration(userReportedIntegration); 
        
               // Navigate to the next onboarding step with the selected integration 
        
               Navigation.navigate(ROUTES.ONBOARDING_INTERESTED_FEATURES.getRoute(route.params?.backTo)); 
        
           }, [translate, userReportedIntegration, route.params?.backTo]);

we are navigating to more feature here with out checking if the user already went through BaseOnboardingPersonalDetails or not

What changes do you think we should make in order to solve the problem?

we need to check if BaseOnboardingPersonalDetails step is completed in case of private domain with accessible policy where user already enter their name and then navigate the user to ONBOARDING_INTERESTED_FEATURES if not then navigate them to BaseOnboardingPersonalDetails

here

App/src/libs/actions/Welcome/OnboardingFlow.ts

Lines 125 to 127 in b04e219

    
           if (!isUserFromPublicDomain && hasAccessiblePolicies) { 
        
               return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`; 
        
           }

we check if the user if from private domain and has accessible policies so we navigate them to ONBOARDING_PERSONAL_DETAILS

we can check this same in BaseOnboardingAccounting to find out that user already entered their name.

const isPrivateDomainAndHasAccessiblePolicies = !account?.isFromPublicDomain && !!account?.hasAccessibleDomainPolicies;

const handleContinue = useCallback(() => {
    if (userReportedIntegration === undefined) {
        setError(translate('onboarding.errorSelection'));
        return;
    }

    setOnboardingUserReportedIntegration(userReportedIntegration);

    const nextRoute = isPrivateDomainAndHasAccessiblePolicies
        ? ROUTES.ONBOARDING_INTERESTED_FEATURES.getRoute(route.params?.backTo)
        : ROUTES.ONBOARDING_PERSONAL_DETAILS.getRoute(route.params?.backTo);
    Navigation.navigate(nextRoute);
}, [translate, userReportedIntegration, route.params?.backTo, isPrivateDomainAndHasAccessiblePolicies]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

For a normal ND flow when user signup and select

manage team
cohort 1-10
Accounting software
Personal details

there will be no logic to navigate the user to InterestedFeatures page from PersonalDetails page after fixing this bug so we should include the check to handle this case in PersonalDetails page

here

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 99 to 103 in b04e219

    
           if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) { 
        
               updateDisplayName(firstName, lastName); 
        
               Navigation.navigate(ROUTES.ONBOARDING_WORKSPACE.getRoute(route.params?.backTo)); 
        
               return; 
        
           }

we should add this check, to navigate the user to ONBOARDING_INTERESTED_FEATURES page from personal details

if (!isPrivateDomainAndHasAccessiblePolicies && onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    Navigation.navigate(ROUTES.ONBOARDING_INTERESTED_FEATURES.getRoute(route.params?.backTo));
    return;
}

Proposal

Please re-state the problem that we are trying to solve in this issue.

No "What's your name?" modal if Manage my teams selected, it caused once user select Manage my team’s expenses it's gonna be Navigate to manage employee directly. Not setup the Personal Details

What is the root cause of that problem?

In this flow the system will be check to navigate routes, Once user select Manage my team’s expenses will be Navigate to onboarding/employees route directly

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Lines 86 to 89 in 13af4fa

    
           if (choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) { 
        
               Navigation.navigate(ROUTES.ONBOARDING_EMPLOYEES.getRoute(route.params?.backTo)); 
        
               return; 
        
           }

What changes do you think we should make in order to solve the problem?

Remove this line

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Lines 86 to 89 in 13af4fa

    
           if (choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) { 
        
               Navigation.navigate(ROUTES.ONBOARDING_EMPLOYEES.getRoute(route.params?.backTo)); 
        
               return; 
        
           }

let's the system navigate to personal details

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Line 108 in 13af4fa

    
           Navigation.navigate(ROUTES.ONBOARDING_PERSONAL_DETAILS.getRoute(route.params?.backTo));

And added the conditional for this

if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
     updateDisplayName( firstName, lastName );
     Navigation.navigate( ROUTES.ONBOARDING_EMPLOYEES.getRoute( route.params?.backTo ) );
     return
}

in this line

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Line 107 in 13af4fa

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2025-07-24.at.10.34.10.mp4

So the flow for OnboardingPurpose will be same to setup First and last name first

Job added to Upwork: https://www.upwork.com/jobs/~021949891158079943967

@rushatgabhane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

first proposal seems good to me #67008 (comment)

🎀👀🎀

Automation failed, switching this to daily to action tomorrow

BugZero Checklist:

[Contributor] Classify the bug: this is a new change request

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: this is a new requirement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Signup with private email that does not have any workspace to join or signup with public email
Choose Manage team
Choose 1-10 members
Choose accounting integration
Press Continue and verify it navigate to interested features page
Press continue and finish the onboarding

Do we agree 👍 or 👎

@samranahm

Payment summary:

@samranahm paid $125 via Upwork
@rushatgabhane due $125 via NewDot manual request
@DylanDylann due $250 via NewDot manual request

@bfitzexpensify

@bfitzexpensify I haven’t received new offer on Upwork yet.

@bfitzexpensify

@bfitzexpensify gentle bump #67008 (comment)

@samranahm

Hi @samranahm this was paid via https://www.upwork.com/jobs/~021949891158079943967

@bfitzexpensify

@bfitzexpensify We had another PR, the original Issue was already paid and closed.

Please take a look #67008 (comment)

Yes, the follow on PR was to fix the regressions caused by the original PR. We don't pay for a second PR if it was only required because of issues with the first.

@DylanDylann

$250 approved for @DylanDylann

Navigation Menu

[Due for payment 2025-09-19] [Due for payment 2025-08-15] [$250] [EX-50] No "What's your name?" modal if Manage my teams selected #67008

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Result

79 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const handleContinue = useCallback(() => {
	if (userReportedIntegration === undefined) {
	setError(translate('onboarding.errorSelection'));
	return;
	}

	setOnboardingUserReportedIntegration(userReportedIntegration);

	// Navigate to the next onboarding step with the selected integration
	Navigation.navigate(ROUTES.ONBOARDING_INTERESTED_FEATURES.getRoute(route.params?.backTo));
	}, [translate, userReportedIntegration, route.params?.backTo]);

	if (!isUserFromPublicDomain && hasAccessiblePolicies) {
	return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`;
	}

	if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND \|\| onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) {
	updateDisplayName(firstName, lastName);
	Navigation.navigate(ROUTES.ONBOARDING_WORKSPACE.getRoute(route.params?.backTo));
	return;
	}

	if (choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	Navigation.navigate(ROUTES.ONBOARDING_EMPLOYEES.getRoute(route.params?.backTo));
	return;
	}

[Due for payment 2025-09-19] [Due for payment 2025-08-15] [$250] [EX-50] No "What's your name?" modal if Manage my teams selected #67008

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 23, 2025

samranahm commented on Jul 23, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

andriferry commented on Jul 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Result

melvin-bot commented on Jul 28, 2025

melvin-bot commented on Jul 28, 2025

rushatgabhane commented on Jul 28, 2025

79 remaining items

bfitzexpensify commented on Sep 23, 2025

DylanDylann commented on Sep 25, 2025

BugZero Checklist:

Regression Test Proposal

Test:

bfitzexpensify commented on Sep 25, 2025

samranahm commented on Sep 25, 2025

samranahm commented on Sep 25, 2025

bfitzexpensify commented on Sep 26, 2025

samranahm commented on Sep 26, 2025

samranahm commented on Sep 26, 2025

bfitzexpensify commented on Sep 26, 2025

garrettmknight commented on Nov 11, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions