You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-26] Remove call to getReportNameValuePairs() in method getReportNameInternal from ReportUtils.ts #67094
🔔 Note for Contributors: Please ensure that you are responsible in the PR phase to try to get it done soon
The function getReportNameInternal() is not a pure function because it references the report's NVPs from a global variable here. This is considered an anti-pattern that we are actively working to eliminate.
✅ Your Task
Verify that a unit test exists for getReportNameInternal() in its current form. If it doesn't, create one — and aim for high-quality, thorough coverage.
Refactor getReportNameInternal() into a pure function, and introduce a new parameter: isReportArchived = false (It is recommended to use useReportIsArchived to get isReportArchived). And update all instances in the codebase where getReportNameInternal() is called to accommodate the new isReportArchived parameter.
⚠️ Best Practices to Follow
Avoid adding new global references to data via Onyx.connect.
Avoid using isArchivedReport(nameValuePairs) unless absolutely necessary.
Prefer fetching data in a UI component, then pass it down via parameters.
Consider using the useReportIsArchived() React hook — it’s designed for this.
Before making changes, check if the report's NVPs are already available or if isReportArchived is already calculated or passed.
Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
getReportNameValuePairs()#59961melvin-bot commentedon Jul 24, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Tony-MK commentedon Jul 24, 2025
@tgolen, could I work on this one?
DylanDylann commentedon Jul 24, 2025
🔔 Note for Contributors: Please ensure that you are responsible in the PR phase to try to get it done soon
The function getReportNameInternal() is not a pure function because it references the report's NVPs from a global variable here. This is considered an anti-pattern that we are actively working to eliminate.
✅ Your Task
Verify that a unit test exists for getReportNameInternal() in its current form. If it doesn't, create one — and aim for high-quality, thorough coverage.
Refactor getReportNameInternal() into a pure function, and introduce a new parameter: isReportArchived = false (It is recommended to use useReportIsArchived to get isReportArchived). And update all instances in the codebase where getReportNameInternal() is called to accommodate the new isReportArchived parameter.
DylanDylann commentedon Jul 24, 2025
@Tony-MK please read the above guideline. This may be a big change, let us know if you are able to be responsive and prioritise it.
Tony-MK commentedon Jul 24, 2025
@DylanDylann, Sure, but does it still need a proposal?
54 remaining items
melvin-bot commentedon Sep 26, 2025
Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Sep 26, 2025
Payment Summary
Upwork Job
BugZero Checklist (@bfitzexpensify)
Tony-MK commentedon Sep 28, 2025
Requested payment as per the Payment Summary.
twisterdotcom commentedon Sep 28, 2025
@Tony-K has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
getReportNameValuePairs()in methodgetReportNameInternalfromReportUtils.ts#67094 (comment)Zapier Logs
Run ID: 00040eee-b236-a2e7-77f4-84d6e553e261johncschuster commentedon Sep 29, 2025
Payment Summary
Contributor: @Tony-MK due $250 via NewDot
Contributor+: @DylanDylann due $250 via NewDot
melvin-bot commentedon Sep 30, 2025
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!
johncschuster commentedon Sep 30, 2025
Looks like we can close this up. @DylanDylann don't forget to request payment!
trjExpensify commentedon Nov 24, 2025
approved $250 for @DylanDylann.