You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-10-13] [$250] Expense - Paying the expense removed the amount violation, but it re-appeared later #67328
Version Number: 9.1.87-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Launch app
Create a Workspace
Tap overview - change plan to control
Go to workspace chat
Create a manual expense with 8 digit number which shows violation for amount
Submit, approve and pay elsewhere via top dropdown
Expected Result:
Paying the expense must remove the amount violation
Actual Result:
Paying the expense removed the amount violation, but it re-appeared later
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6902024_1753797937249.Screenrecorder-2025-07-29-19-27-56-979.mp4
Or we can easily set receiptImageViolations, receiptViolations to be empty for settled reports here so that no receipt RBR will be shown.
May be also the transaction error here but it is not a violation so we might still need to display it for settled reports too.
And also avoid the RBR's in TransactionItemRow here
but if we want to show non-violation errors like the transaction errors we can explicitly avoid violations in case of a settled report in ViolationsUtils.getRBRMessages
If needed we can also avoid RBRs for errors linked to settled reports in getReasonAndReportActionThatHasRedBrickRoad but for violations we are already not including settled report's violations in the calculation here.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
changed the title [-]Expense - Paying the expense removed the amount violation, but it re-appeared later[/-][+][$250] Expense - Paying the expense removed the amount violation, but it re-appeared later[/+]on Aug 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox / @FitseTLT@JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A Cause by the logic was updated following backend changes.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Create a Workspace
More feature -> enable rule
Open Rules -> Update Max expense amount
Create a manual expense has value greater than the value has updated from step 3
Submit, approve and pay elsewhere via top dropdown
Verify paying the expense will remove RBR from the LHN and report preview and transaction item from the transaction list but the violation will be seen on the details transaction view.
Activity
melvin-bot commentedon Jul 29, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Jul 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - Paying the expense removed the amount violation, but it re-appeared later
What is the root cause of that problem?
We remove the violations when we pay optimstically so it disappears but the BE is adding it back so it re-appears.
What changes do you think we should make in order to solve the problem?
This can be solved in BE but we also avoid showing RBR's in FE when the iou report is settled ones like we do here
App/src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx
Line 355 in 59ab268
So we can implement the same solution for MoneyRequestView
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 328 to 329 in 59ab268
Similarly we can avoid showing receipt audit violations for settled report's.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 565 to 571 in 59ab268
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 636 in 59ab268
Or we can easily set receiptImageViolations, receiptViolations to be empty for settled reports here so that no receipt RBR will be shown.
May be also the transaction error here but it is not a violation so we might still need to display it for settled reports too.
And also avoid the RBR's in TransactionItemRow here
App/src/components/TransactionItemRow/index.tsx
Lines 429 to 433 in 59ab268
App/src/components/TransactionItemRow/index.tsx
Lines 462 to 464 in 59ab268
but if we want to show non-violation errors like the transaction errors we can explicitly avoid violations in case of a settled report in
ViolationsUtils.getRBRMessagesIf needed we can also avoid RBRs for errors linked to settled reports in
getReasonAndReportActionThatHasRedBrickRoadbut for violations we are already not including settled report's violations in the calculation here.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Aug 1, 2025
@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 5, 2025
@JmillsExpensify Still overdue 6 days?! Let's take care of this!
[-]Expense - Paying the expense removed the amount violation, but it re-appeared later[/-][+][$250] Expense - Paying the expense removed the amount violation, but it re-appeared later[/+]melvin-bot commentedon Aug 6, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021953013986992609495
melvin-bot commentedon Aug 6, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)32 remaining items
melvin-bot commentedon Oct 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-10-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 6, 2025
@suneox / @FitseTLT @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JmillsExpensify commentedon Oct 16, 2025
Payment summary:
JmillsExpensify commentedon Oct 16, 2025
Contributor paid out. @suneox mind commenting on the regression test?
suneox commentedon Oct 16, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A Cause by the logic was updated following backend changes.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Max expense amountDo we agree 👍 or 👎
JmillsExpensify commentedon Oct 17, 2025
Awesome thanks. Please request via ND!
twisterdotcom commentedon Oct 26, 2025
@suneox has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-f690-af18-857b-81f7331e5081