Skip to content

[Due for payment 2025-11-20][$250] Enable prefer-set-has lint rule #67421

Closed
Expensify/eslint-config-expensify
#164

Description

@roryabraham

Coming from #67420


Problem

When arrays are used only for .includes and the order of elements does not matter, then performance degrades due to repeated linear-time lookups, particularly for large arrays or frequent calls to .includes.

Solution

Enable eslint-plugin-unicorn’s prefer-set-has rule to enforce that arrays are not used only for .includes calls. There are some cases when using a Set instead of an array won’t materially improve performance, but the overhead of using a Set is typically negligible, while the overhead of using an array is sometimes quite significant.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021968163349191777005
  • Upwork Job ID: 1968163349191777005
  • Last Price Increase: 2025-10-17
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. self-assigned this
    on Jul 30, 2025
  2. moved this from LOW to HIGH in [#whatsnext] #qualityon Jul 30, 2025
  3. roryabraham commented on Sep 2, 2025

    @roryabraham
    ContributorAuthor

    Looking for a team of two volunteers to take this on: https://expensify.slack.com/archives/C08CZDJFJ77/p1756853317764529

  4. roryabraham commented on Sep 12, 2025

    @roryabraham
    ContributorAuthor

    main PR is awaiting my review, and I'll try to do it tomorrow: Expensify/eslint-config-expensify#153

  5. 88 remaining items

  6. changed the title [-][Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/-] [+][Due for payment 2025-11-20] [Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/+] on Nov 13, 2025
  7. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.57-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sobitneupane requires payment through NewDot Manual Requests
    • @gelocraft requires payment (Needs manual offer from BZ)
  8. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. gelocraft commented on Nov 20, 2025

    @gelocraft
    Contributor

    @sobitneupane @roryabraham @lschurr

    It's been a week and nothing has been reverted

  10. changed the title [-][Due for payment 2025-11-20] [Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/-] [+][Due for payment 2025-11-20][$250] Enable prefer-set-has lint rule[/+] on Nov 20, 2025
  11. lschurr commented on Nov 20, 2025

    @lschurr
    Contributor

    Payment Summary

    Contributor: @gelocraft paid $250 via Upwork
    Contributor+: @sobitneupane due $250 via NewDot

  12. lschurr commented on Nov 20, 2025

    @lschurr
    Contributor

    All set.

  13. gelocraft commented on Nov 20, 2025

    @gelocraft
    Contributor

    received

    @lschurr thanks!

  14. quinthar commented on Dec 8, 2025

    @quinthar
    Contributor

    Approved $250 to @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions