You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-20][$250] Enable prefer-set-has lint rule #67421
When arrays are used only for .includes and the order of elements does not matter, then performance degrades due to repeated linear-time lookups, particularly for large arrays or frequent calls to .includes.
Solution
Enable eslint-plugin-unicorn’s prefer-set-has rule to enforce that arrays are not used only for .includes calls. There are some cases when using a Set instead of an array won’t materially improve performance, but the overhead of using a Set is typically negligible, while the overhead of using an array is sometimes quite significant.
changed the title [-][Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/-][+][Due for payment 2025-11-20] [Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/+]on Nov 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.57-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-11-20] [Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/-][+][Due for payment 2025-11-20][$250] Enable prefer-set-has lint rule[/+]on Nov 20, 2025
Activity
roryabraham commentedon Aug 20, 2025
https://expensify.slack.com/archives/C05LX9D6E07/p1755719761872409?thread_ts=1755719385.116499&cid=C05LX9D6E07
roryabraham commentedon Sep 2, 2025
Looking for a team of two volunteers to take this on: https://expensify.slack.com/archives/C08CZDJFJ77/p1756853317764529
roryabraham commentedon Sep 12, 2025
main PR is awaiting my review, and I'll try to do it tomorrow: Expensify/eslint-config-expensify#153
88 remaining items
[-][Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/-][+][Due for payment 2025-11-20] [Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/+]melvin-bot commentedon Nov 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.57-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
unicorn/prefer-set-hasviolations #74773If no regressions arise, payment will be issued on 2025-11-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 13, 2025
@sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
gelocraft commentedon Nov 20, 2025
@sobitneupane @roryabraham @lschurr
It's been a week and nothing has been reverted
[-][Due for payment 2025-11-20] [Due for payment 2025-11-19] [Due for payment 2025-11-17] [$250] Enable prefer-set-has lint rule[/-][+][Due for payment 2025-11-20][$250] Enable prefer-set-has lint rule[/+]lschurr commentedon Nov 20, 2025
Payment Summary
Contributor: @gelocraft paid $250 via Upwork
Contributor+: @sobitneupane due $250 via NewDot
lschurr commentedon Nov 20, 2025
All set.
gelocraft commentedon Nov 20, 2025
received
@lschurr thanks!
quinthar commentedon Dec 8, 2025
Approved $250 to @sobitneupane