Skip to content

[Due for payment 2025-09-23] [$250] Expensify card - Not here page when open card from another feed #67491

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.87-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
**If this was caught during regression testing, add the test name, ID and link from TestRail:**KI retest #65638
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Other

Action Performed:

Precondition:

  1. User is logged in ND with applause.expensifail.com account.
  2. Workspace A and B are set up with Expensify Card.
  3. Workspace A has at least one other member other than the workspace owner.

STR:

  1. Go to Workspace A settings > Expensify Card.
  2. Open the Expensify Card feed selector.
  3. Select the card feed from Workspace B.
  4. Go to Members > Click on the member.
  5. Click + New card > Go through the process of adding VIRTUAL card and reach confirmation page.
  6. On the confirmation page, click Issue card.
  7. Repeat steps 2-4 with feed from Workspace A
  8. Go to Members > click on member
  9. Click on both cards in Assigned cards

Expected Result:

Card details tab opened for both cards

Actual Result:

Card details tab opened for card from WS A.
Not here page opened for card from WS B

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021953484760738718185
  • Upwork Job ID: 1953484760738718185
  • Last Price Increase: 2025-08-14
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2025
  2. melvin-bot commented on Jul 31, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    @abekkala Huh... This is 4 days overdue. Who can take care of this?

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 7, 2025
  5. changed the title [-]Expensify card - Not here page when open card from another feed[/-] [+][$250] Expensify card - Not here page when open card from another feed[/+] on Aug 7, 2025
  6. melvin-bot commented on Aug 7, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 7, 2025
  8. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  9. mukhrr commented on Aug 9, 2025

    @mukhrr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The card details page can’t find a card when opened from different feed.

    What is the root cause of that problem?

    Cards details was rendered based on last selected WS settings where useDefaultFundID gives it.
    And in WorkspaceExpensifyCardDetailsPage.tsx cardsList were coming from last selected WS on Expensify Cards page when you selected from dropdown.

    Pay attention to defaultFundID here:

    const [cardsList, cardsListResult] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${defaultFundID}_${CONST.EXPENSIFY_CARD.BANK}`, {
          selector: filterInactiveCards,
          canBeMissing: true,
    });
    
    

    What changes do you think we should make in order to solve the problem?

    We need to get all WS cards and show by cardId on details on L64 in WorkspaceExpensifyCardDetailsPage:

    const card = workspaceCards?.[cardID];
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • Card exists only under cards_<fundID>_Expensify Card: details page finds and renders it.
    • Card exists only under cards_<workspaceAccountID>_Expensify Card: details page finds and renders it.
    • Card exists under both keys: details page still renders the correct card.
    • Card is inactive/closed: details page shows Not Found (consistent with existing filtering).
    • Loading state: while WORKSPACE_CARDS_LIST is loading, page doesn’t incorrectly show Not Found.

    What alternative solutions did you explore? (Optional)

    I thought about passing WS settings to useDefaultFundID to prevent it from using lastSelected settings. But i guess this is a bit overhead.

  10. hoangzinh commented on Aug 12, 2025

    @hoangzinh
    Contributor

    Thank you for posting proposal, @mukhrr. I will try to review it soon.

  11. 27 remaining items

  12. changed the title [-][$250] Expensify card - Not here page when open card from another feed[/-] [+][Due for payment 2025-09-23] [$250] Expensify card - Not here page when open card from another feed[/+] on Sep 16, 2025
  13. melvin-bot commented on Sep 16, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Sep 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.14-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment through NewDot Manual Requests
    • @mukhrr requires payment (Needs manual offer from BZ)
  15. melvin-bot commented on Sep 16, 2025

    @melvin-bot

    @hoangzinh @abekkala The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. abekkala commented on Sep 18, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR SEPT 23

    • Fix: @mukhrr [$250, if no regressions] payment via Upwork - OFFER
    • PR Review: @hoangzinh [$250, if no regressions] payment via NewDot
      please complete checklist
  17. hoangzinh commented on Sep 20, 2025

    @hoangzinh
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    Regression Test Proposal

    Precondition:

    1. User is logged in ND with applause.expensifail.com account.
    2. Workspace A and B are set up with Expensify Card.
    3. Workspace A has at least one other member other than the workspace owner.

    Test:

    1. Go to Workspace A settings > Expensify Card.
    2. Open the Expensify Card feed selector.
    3. Select the card feed from Workspace B.
    4. Go to Members > Click on the member.
    5. Click + New card > Go through the process of adding VIRTUAL card and reach confirmation page.
    6. On the confirmation page, click Issue card.
    7. Repeat steps 2-4 with feed from Workspace A
    8. Go to Members > click on member
    9. Click on both cards in Assigned cards
    10. Verify that Card details tab opened for both cards

    Do we agree 👍 or 👎

  18. abekkala commented on Sep 23, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR SEPT 23

    • Fix: @mukhrr [$250] payment sent via Upwork - thank you! 🎉
    • PR Review: @hoangzinh [$250] payment will be made via NewDot
      thanks! 🎉
  19. hoangzinh commented on Sep 24, 2025

    @hoangzinh
    Contributor

    Thanks @abekkala. I requested in ND

  20. garrettmknight commented on Sep 30, 2025

    @garrettmknight
    Contributor

    $250 approved for @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions