Skip to content

[Due for payment 2025-09-02] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY in src/libs/actions/ReimbursementAccount/resetNonUSDBankAccount.ts #67563

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2025
  2. tgolen commented on Jul 31, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 31, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. allgandalf commented on Aug 3, 2025

    @allgandalf
    Contributor
  5. 12 remaining items

  6. melvin-bot commented on Sep 2, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @allgandalf is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 2, 2025
  8. melvin-bot commented on Sep 2, 2025

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 2, 2025
  10. melvin-bot commented on Sep 2, 2025

    @melvin-bot

    Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

  11. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 2, 2025
  12. mallenexpensify commented on Sep 2, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @allgandalf paid $250 via Upwork
    Contributor+: @DylanDylann due $250 via NewDot

    @allgandalf can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021963024454997680360

  13. allgandalf commented on Sep 3, 2025

    @allgandalf
    Contributor

    I accepted the offer, thanks!

  14. mallenexpensify commented on Sep 4, 2025

    @mallenexpensify
    Contributor

    @allgandalf paid, payment summary updated above.

  15. garrettmknight commented on Nov 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions