Skip to content

[Payment Due] Remove Onyx.connect() for the key: ONYXKEYS.FUND_LIST in src/libs/shouldRenderTransferOwnerButton/index.native.ts #67572

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2025
  2. tgolen commented on Jul 31, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Jul 31, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. 7 remaining items

  5. danieldoglas commented on Aug 20, 2025

    @danieldoglas
    Contributor

    My bad, I assigned it wrongly. Done.

  6. danieldoglas commented on Aug 21, 2025

    @danieldoglas
    Contributor

    Merged this one. $250 owed.

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 8, 2025
  8. allgandalf commented on Sep 8, 2025

    @allgandalf
    Contributor

    automation failed, this one is ready for payment

  9. danieldoglas commented on Sep 8, 2025

    @danieldoglas
    Contributor

    @sakluger this one is ready for payment, let me know if you need anything else on my side.

  10. sakluger commented on Sep 9, 2025

    @sakluger
    Contributor

    Payment Summary

    Contributor: @allgandalf due $250 via Upwork: Sent offer
    Contributor+: @DylanDylann $250 via Newdot

    @allgandalf please let me know once you've accepted the Upwork offer, thanks!

  11. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.FUND_LIST` in `src/libs/shouldRenderTransferOwnerButton/index.native.ts`[/-] [+][Payment Due] Remove `Onyx.connect()` for the key: `ONYXKEYS.FUND_LIST` in `src/libs/shouldRenderTransferOwnerButton/index.native.ts`[/+] on Sep 9, 2025
  12. allgandalf commented on Sep 9, 2025

    @allgandalf
    Contributor

    @allgandalf please let me know once you've accepted the Upwork offer, thanks!

    I accepted the offer, thanks!

  13. sakluger commented on Sep 10, 2025

    @sakluger
    Contributor

    Thank you! All paid.

  14. garrettmknight commented on Nov 1, 2025

    @garrettmknight
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions