Skip to content

[HOLD for payment 2022-01-17] [HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components #6760

Closed

Description

@puneetlath

We currently have four components that are effectively shadows of React Native components:

  • ExpensiPicker
  • ExpensiTextInput
  • ExpensifyButton
  • ExpensifyText

Now that we've added a rule in our ESLint config to restrict importing Text, Button, TextInput or Picker from react-native we no longer need to have these strange names for our components. We can just name our custom components Text, Button, TextInput and Picker and if anyone gets confused and accidentally imports the one from React Native instead of using our custom component the linter will let them know.

We'll need to rename the files for these components as well as update the name anywhere they are used. There are likely 100+ files that will need to be edited, so let's break this up into one PR per component.

More context on this in this thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1639149638008700

There are four $250 milestones. One for each component. Upwork job is here: https://www.upwork.com/jobs/~0101fc66184e3bd51b

Activity

  1. MelvinBot commented on Dec 14, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  2. MelvinBot commented on Dec 14, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @parasharrajat (Exported)

  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 14, 2021
  4. MelvinBot commented on Dec 14, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  5. puneetlath commented on Dec 14, 2021

    @puneetlath
    ContributorAuthor

    @dylanexpensify I already created the job, so no need to worry about it. @pecanoro I can handle this one from the engineering perspective. Assigning both of y'all.

  6. 22 remaining items

  7. added and removed on Dec 28, 2021
  8. botify commented on Dec 28, 2021

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.23-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-04. 🎊

  9. changed the title [-][HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-] [+][HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+] on Dec 28, 2021
  10. added and removed on Jan 4, 2022
  11. botify commented on Jan 4, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-11. 🎊

  12. changed the title [-][HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-] [+][HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+] on Jan 4, 2022
  13. added and removed on Jan 10, 2022
  14. changed the title [-][HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-] [+][HOLD for payment 2022-01-17] [HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+] on Jan 10, 2022
  15. botify commented on Jan 10, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-17. 🎊

  16. puneetlath commented on Jan 12, 2022

    @puneetlath
    ContributorAuthor

    Has already been paid out when the first PR merged, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions