You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-01-17] [HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components #6760
We currently have four components that are effectively shadows of React Native components:
ExpensiPicker
ExpensiTextInput
ExpensifyButton
ExpensifyText
Now that we've added a rule in our ESLint config to restrict importing Text, Button, TextInput or Picker from react-native we no longer need to have these strange names for our components. We can just name our custom components Text, Button, TextInput and Picker and if anyone gets confused and accidentally imports the one from React Native instead of using our custom component the linter will let them know.
We'll need to rename the files for these components as well as update the name anywhere they are used. There are likely 100+ files that will need to be edited, so let's break this up into one PR per component.
@dylanexpensify I already created the job, so no need to worry about it. @pecanoro I can handle this one from the engineering perspective. Assigning both of y'all.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.23-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-][+][HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+]on Dec 28, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-][+][HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+]on Jan 4, 2022
changed the title [-][HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-][+][HOLD for payment 2022-01-17] [HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+]on Jan 10, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
MelvinBot commentedon Dec 14, 2021
Triggered auto assignment to @dylanexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.MelvinBot commentedon Dec 14, 2021
Triggered auto assignment to @parasharrajat (
Exported)MelvinBot commentedon Dec 14, 2021
Triggered auto assignment to @pecanoro (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.puneetlath commentedon Dec 14, 2021
@dylanexpensify I already created the job, so no need to worry about it. @pecanoro I can handle this one from the engineering perspective. Assigning both of y'all.
22 remaining items
botify commentedon Dec 28, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.23-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-04. 🎊
[-][HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-][+][HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+]botify commentedon Jan 4, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-11. 🎊
[-][HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-][+][HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+][-][HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/-][+][HOLD for payment 2022-01-17] [HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components[/+]botify commentedon Jan 10, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-17. 🎊
puneetlath commentedon Jan 12, 2022
Has already been paid out when the first PR merged, so closing.