You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of param interestedFeatures, how about selectedFeatures. I feel like the latter is simpler to understand.
Instead of Record<string, boolean>, how about just a string array. I ask because to me it makes sense to just send the ones selected. I dont see a reason to select the others. I say this because the backend is normally our source of truth and it should already have all the features list and hence we only need the ones that are selected.
Sorry for the delay, @chiragsalian's suggestion looks good, I just updated the proposal. Please let me know when the BE is done then I can raise the PR on FE side.
changed the title [-][Due for payment 2025-11-03] [Due for payment 2025-10-27] [$250] Improve ex50 onboarding flow[/-][+][$250] Improve ex50 onboarding flow[/+]on Nov 5, 2025
Verify that the "What features are you interested in?" is displayed
Select/unselect any options
Complete the onboarding process
Go to networks tab and verify that the CreateWorkspace is called but CreateWorkspace, UpgradeToCorporate, EnablePolicyDistanceRates , EnablePolicyExpensifyCards, SetPolicyRulesEnabled, EnablePolicyInvoicing are not
Activity
melvin-bot commentedon Aug 1, 2025
Triggered auto assignment to @Gonals (
AutoAssignerNewDotQuality)dukenv0307 commentedon Aug 1, 2025
Here are the current parameters of the CreateWorkspace API
App/src/libs/actions/Policy/Policy.ts
Lines 2197 to 2214 in 60677bc
We can add the new one named
selectedFeaturesBy doing this way, we don't need to call UpgradeToCorporate, TogglePolicyPerDiem and EnablePolicyFeature APIs during onboarding flow
Same as what we returned when calling these APIs above
dukenv0307 commentedon Aug 1, 2025
@chiragsalian I created this PR to improve the ex50 onboarding flow. I also propose the new update in here, can you please take a look?
chiragsalian commentedon Aug 1, 2025
Neat, thanks for making the issue.
Proposal mostly LGTM.
Some thoughts,
interestedFeatures, how aboutselectedFeatures. I feel like the latter is simpler to understand.Thoughts?
melvin-bot commentedon Aug 6, 2025
@chiragsalian, @Gonals Huh... This is 4 days overdue. Who can take care of this?
Gonals commentedon Aug 7, 2025
Bump @dukenv0307 ⬆️
dukenv0307 commentedon Aug 7, 2025
Sorry for the delay, @chiragsalian's suggestion looks good, I just updated the proposal. Please let me know when the BE is done then I can raise the PR on FE side.
chiragsalian commentedon Aug 7, 2025
Proposal LGTM. @Gonals do you wanna work on this or would you prefer if i or someone else tackle it?
62 remaining items
[-][Due for payment 2025-11-03] [Due for payment 2025-10-27] [$250] Improve ex50 onboarding flow[/-][+][$250] Improve ex50 onboarding flow[/+]greg-schroeder commentedon Nov 5, 2025
This one is a bit difficult to follow, so I'll try and break it down:
So, I think that means the following payment summary is correct:
Author: @dukenv0307 - $125 - ND payments
Reviewer: @thesahindia - $125 - ND payments
Approved for the above ☝️
greg-schroeder commentedon Nov 5, 2025
@dukenv0307 Does this one need a regression test? We can proceed with the checklist to close things out here
[-][$250] Improve ex50 onboarding flow[/-][+][C+ Checklist Needs Completion][$250] Improve ex50 onboarding flow[/+][-][C+ Checklist Needs Completion][$250] Improve ex50 onboarding flow[/-][+][C+ Checklist Needs Completion] [$250] Improve ex50 onboarding flow[/+]dukenv0307 commentedon Nov 6, 2025
@thesahindia can you please complete the checklist as you're the C+ here?
thesahindia commentedon Nov 9, 2025
Test case steps:
trjExpensify commentedon Jan 23, 2026
approved $125 for @thesahindia
quinthar commentedon Mar 11, 2026
Approved $125 to @dukenv0307