Skip to content

[C+ Checklist Needs Completion] [$250] Improve ex50 onboarding flow #67642

Closed

Description

@dukenv0307

Original GH: #65326

Action Performed:

Break down in numbered steps

  1. Login with the new account
  2. Choose Manage my team's expense
  3. Choose 1-10 employees
  4. Choose any accounting software
  5. Verify that the What features are you interested in? is shown
  6. Try to select/unselect any options
  7. Complete the onboarding process

Expected Result:

For enabling the policy features, we should do it in CreateWorkspace

Actual Result:

We're calling too many APIs:

  • CreateWorkspace
  • UpgradeToCorporate
  • EnablePolicyDistanceRates
  • EnablePolicyExpensifyCards
  • SetPolicyRulesEnabled
  • EnablePolicyInvoicing
  • ...

Screenshots/Videos

Add any screenshot/video evidence
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021970960632882029863
  • Upwork Job ID: 1970960632882029863
  • Last Price Increase: 2025-11-03
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 1, 2025
  2. melvin-bot commented on Aug 1, 2025

    @melvin-bot

    Triggered auto assignment to @Gonals (AutoAssignerNewDotQuality)

  3. dukenv0307 commented on Aug 1, 2025

    @dukenv0307
    ContributorAuthor
    • API Endpoint: CreateWorkspace
    • Params:
      Here are the current parameters of the CreateWorkspace API

    const params: CreateWorkspaceParams = {
    policyID,
    adminsChatReportID,
    expenseChatReportID,
    ownerEmail: policyOwnerEmail,
    makeMeAdmin,
    policyName: workspaceName,
    type: workspaceType,
    adminsCreatedReportActionID,
    expenseCreatedReportActionID,
    customUnitID,
    customUnitRateID,
    engagementChoice,
    currency: outputCurrency,
    file: clonedFile,
    companySize,
    userReportedIntegration: userReportedIntegration ?? undefined,
    };

    We can add the new one named selectedFeatures

    selectedFeatures: Array<string>
    

    By doing this way, we don't need to call UpgradeToCorporate, TogglePolicyPerDiem and EnablePolicyFeature APIs during onboarding flow

    • Onyx push data

    Same as what we returned when calling these APIs above

  4. dukenv0307 commented on Aug 1, 2025

    @dukenv0307
    ContributorAuthor

    @chiragsalian I created this PR to improve the ex50 onboarding flow. I also propose the new update in here, can you please take a look?

  5. chiragsalian commented on Aug 1, 2025

    @chiragsalian
    Contributor

    Neat, thanks for making the issue.

    Proposal mostly LGTM.
    Some thoughts,

    1. Instead of param interestedFeatures, how about selectedFeatures. I feel like the latter is simpler to understand.
    2. Instead of Record<string, boolean>, how about just a string array. I ask because to me it makes sense to just send the ones selected. I dont see a reason to select the others. I say this because the backend is normally our source of truth and it should already have all the features list and hence we only need the ones that are selected.

    Thoughts?

  6. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    @chiragsalian, @Gonals Huh... This is 4 days overdue. Who can take care of this?

  7. Gonals commented on Aug 7, 2025

    @Gonals
    Contributor

    Bump @dukenv0307 ⬆️

  8. dukenv0307 commented on Aug 7, 2025

    @dukenv0307
    ContributorAuthor

    Sorry for the delay, @chiragsalian's suggestion looks good, I just updated the proposal. Please let me know when the BE is done then I can raise the PR on FE side.

  9. chiragsalian commented on Aug 7, 2025

    @chiragsalian
    Contributor

    Proposal LGTM. @Gonals do you wanna work on this or would you prefer if i or someone else tackle it?

  10. 62 remaining items

  11. changed the title [-][Due for payment 2025-11-03] [Due for payment 2025-10-27] [$250] Improve ex50 onboarding flow[/-] [+][$250] Improve ex50 onboarding flow[/+] on Nov 5, 2025
  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 5, 2025
  13. greg-schroeder commented on Nov 5, 2025

    @greg-schroeder
    Contributor

    This one is a bit difficult to follow, so I'll try and break it down:


    So, I think that means the following payment summary is correct:

    Author: @dukenv0307 - $125 - ND payments
    Reviewer: @thesahindia - $125 - ND payments

    Approved for the above ☝️

  14. greg-schroeder commented on Nov 5, 2025

    @greg-schroeder
    Contributor

    @dukenv0307 Does this one need a regression test? We can proceed with the checklist to close things out here

  15. changed the title [-][$250] Improve ex50 onboarding flow[/-] [+][C+ Checklist Needs Completion][$250] Improve ex50 onboarding flow[/+] on Nov 5, 2025
  16. changed the title [-][C+ Checklist Needs Completion][$250] Improve ex50 onboarding flow[/-] [+][C+ Checklist Needs Completion] [$250] Improve ex50 onboarding flow[/+] on Nov 5, 2025
  17. dukenv0307 commented on Nov 6, 2025

    @dukenv0307
    ContributorAuthor

    @thesahindia can you please complete the checklist as you're the C+ here?

  18. thesahindia commented on Nov 9, 2025

    @thesahindia
    Member

    Test case steps:

    1. Login with the a account
    2. Choose "Manage my team's expense"
    3. Choose "1-10 employees"
    4. Choose any accounting software
    5. Verify that the "What features are you interested in?" is displayed
    6. Select/unselect any options
    7. Complete the onboarding process
    8. Go to networks tab and verify that the CreateWorkspace is called but CreateWorkspace, UpgradeToCorporate, EnablePolicyDistanceRates , EnablePolicyExpensifyCards, SetPolicyRulesEnabled, EnablePolicyInvoicing are not
  19. trjExpensify commented on Jan 23, 2026

    @trjExpensify
    Contributor

    approved $125 for @thesahindia

  20. quinthar commented on Mar 11, 2026

    @quinthar
    Contributor

    Approved $125 to @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions