Repository navigation
[Due for payment 2025-09-02] $0 Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.OLD_POLICY_RECENTLY_USED_TAGS in src/libs/migrations/NVPMigration.ts #67669
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/migrations/NVPMigration.ts
- Onyx Key:
ONYXKEYS.COLLECTION.OLD_POLICY_RECENTLY_USED_TAGS - Reference:
Line 61: ONYXKEYS.COLLECTION.OLD_POLICY_RECENTLY_USED_TAGS
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Activity
tgolen commentedon Aug 1, 2025
Warning
DO NOT POST PROPOSALS ON THIS ISSUE!!
Bug-Zero Instructions
src/libs/migrations/NVPMigration.tsto removeOnyx.connect()references #67666melvin-bot commentedon Aug 1, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.tgolen commentedon Aug 4, 2025
Not overdue and should be monthly
8 remaining items
[-]$0 Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.OLD_POLICY_RECENTLY_USED_TAGS` in `src/libs/migrations/NVPMigration.ts`[/-][+][Due for payment 2025-09-02] $0 Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.OLD_POLICY_RECENTLY_USED_TAGS` in `src/libs/migrations/NVPMigration.ts`[/+]melvin-bot commentedon Aug 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 26, 2025
@shubham1206agra / @DylanDylann @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Sep 2, 2025
Payment Summary
Upwork Job
N/A
BugZero Checklist (@twisterdotcom)
twisterdotcom commentedon Sep 3, 2025
I assume we don't need tests for any of these. @tgolen we're just paying these out as and when they're deployed correct? I can close this agreeing with the above payment summary?
shubham1206agra commentedon Sep 3, 2025
@twisterdotcom Payout is $0 here
twisterdotcom commentedon Sep 3, 2025
Okay, glad I checked! I will close now.