Skip to content

[$250] [Due for payment 2025-09-17] Remove Onyx.connect() for the key: ONYXKEYS.NETWORK in src/libs/actions/SignInRedirect.ts #67687

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021968524933353991340
  • Upwork Job ID: 1968524933353991340
  • Last Price Increase: 2025-09-18

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 1, 2025
  2. tgolen commented on Aug 1, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Aug 1, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. pasyukevich commented on Aug 4, 2025

    @pasyukevich
    Contributor

    Hi, I am Eugene from Callstack, an expert agency and I can work on this issue.

  5. 21 remaining items

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 18, 2025
  7. changed the title [-][Due for payment 2025-09-17] Remove `Onyx.connect()` for the key: `ONYXKEYS.NETWORK` in `src/libs/actions/SignInRedirect.ts`[/-] [+][$250] [Due for payment 2025-09-17] Remove `Onyx.connect()` for the key: `ONYXKEYS.NETWORK` in `src/libs/actions/SignInRedirect.ts`[/+] on Sep 18, 2025
  8. melvin-bot commented on Sep 18, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 18, 2025
  10. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 18, 2025
  11. deleted a comment from melvin-bot on Sep 18, 2025
  12. kadiealexander commented on Sep 18, 2025

    @kadiealexander
    Contributor

    @allgandalf sent you an offer.

  13. allgandalf commented on Sep 18, 2025

    @allgandalf
    Contributor

    I accepted, thanks !

  14. kadiealexander commented on Sep 18, 2025

    @kadiealexander
    Contributor

    @allgandalf it's still showing as pending on my side, can you please double check? Link.

  15. allgandalf commented on Sep 18, 2025

    @allgandalf
    Contributor

    oopss, sorry my bad, it happened again, upworks mobile app is buggy, if i accept the offer, it redirects me but doesn't update the backend, sorry for the trouble, can you check again? thanks

  16. kadiealexander commented on Sep 18, 2025

    @kadiealexander
    Contributor

    Classic Upwork! All paid. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions