Skip to content

[AWAITING PAYMENT 2025-12-21]Remove Onyx.connect() for the key: ONYXKEYS.NVP_PREFERRED_LOCALE in src/libs/actions/Session/index.ts #67787

Closed

Description

@danieldoglas

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @brianlee-expensify

Activity

  1. self-assigned this
    on Aug 4, 2025
  2. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 4, 2025
  3. danieldoglas commented on Aug 4, 2025

    @danieldoglas
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  4. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. muttmuure commented on Sep 11, 2025

    @muttmuure
    Contributor

    Not overdue

  6. 16 remaining items

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 4, 2026
  8. melvin-bot commented on Feb 4, 2026

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  9. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PREFERRED_LOCALE` in `src/libs/actions/Session/index.ts`[/-] [+][AWAITING PAYMENT 2025-12-21]Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_PREFERRED_LOCALE` in `src/libs/actions/Session/index.ts`[/+] on Feb 4, 2026
  10. danieldoglas commented on Feb 4, 2026

    @danieldoglas
    ContributorAuthor

    @brianlee-expensify please deal with the payment for this one. It should be $250.

  11. brianlee-expensify commented on Feb 4, 2026

    @brianlee-expensify
    Contributor

    Payment Summary

    Contributor+: @shubham1206agra due $250 via NewDot
    Contributor+: @DylanDylann due $250 via NewDot

  12. JmillsExpensify commented on Mar 18, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

  13. garrettmknight commented on Apr 2, 2026

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions