Skip to content

[Due for payment 2025-10-13] Remove Onyx.connect() for the key: ONYXKEYS.NVP_INTRO_SELECTED in src/libs/actions/Task.ts #67797

Closed

Description

@danieldoglas

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/actions/Task.ts
  • Onyx Key: ONYXKEYS.NVP_INTRO_SELECTED
  • Reference: Line 92: ONYXKEYS.NVP_INTRO_SELECTED

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 4, 2025
  2. danieldoglas commented on Aug 4, 2025

    @danieldoglas
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Aug 4, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. 8 remaining items

  5. changed the title [-]Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_INTRO_SELECTED` in `src/libs/actions/Task.ts`[/-] [+][Due for payment 2025-10-13] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_INTRO_SELECTED` in `src/libs/actions/Task.ts`[/+] on Oct 6, 2025
  6. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-10-13. 🎊

    For reference, here are some details about the assignees on this issue:

  8. melvin-bot commented on Oct 6, 2025

    @melvin-bot

    @parasharrajat / @DylanDylann @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@isabelastisser)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. melvin-bot commented on Oct 13, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@isabelastisser)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. isabelastisser commented on Oct 15, 2025

    @isabelastisser
    Contributor

    Payment summary:

    Reviewer: @parasharrajat owed $250 via NewDot C+ review
    Reviewer: @DylanDylann owed $250 via NewDot - Contributor

  12. parasharrajat commented on Nov 9, 2025

    @parasharrajat
    Member

    Payment requested as per #67797 (comment)

  13. trjExpensify commented on Nov 17, 2025

    @trjExpensify
    Contributor

    approved $250 for @parasharrajat.

  14. JmillsExpensify commented on Mar 24, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions