Repository navigation
[Due for payment 2025-08-19] Categories - Checkbox is not marked as selected when selecting all categories #68058
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.90-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #66780
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace settings > Categories
- Select all the categories via checkbox
Expected Result:
The checkbox will be marked as selected
Actual Result:
The checkbox is not marked as selected when selecting all categories
The same issue happens in other pages such as Tags
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
github-actions commentedon Aug 6, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 6, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 6, 2025
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 6, 2025
💬 A slack conversation has been started in #expensify-open-source
Eskalifer1 commentedon Aug 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Categories - Checkbox is not marked as selected when selecting all categories
What is the root cause of that problem?
The problem is that in this part of the code, we mutate the original object, causing the isSelected value to be added to the original object and the isItemSelected function to start working incorrectly:
App/src/components/SelectionList/BaseSelectionList.tsx
Lines 640 to 643 in 403006c
What changes do you think we should make in order to solve the problem?
We need to clone the object. The easiest way to do this is with “...”
Or use clone when creating an object:
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
7 remaining items
[-]Categories - Checkbox is not marked as selected when selecting all categories[/-][+][Due for payment 2025-08-19] Categories - Checkbox is not marked as selected when selecting all categories[/+]melvin-bot commentedon Aug 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.92-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 12, 2025
@allgandalf @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allgandalf commentedon Aug 15, 2025
Good to close