Skip to content

[$250] Workspace - Expense rule settings are set to 0 for subsequent workspaces after first workspace #68070

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #67477
Email or phone of affected tester (no customers): sjodnjsojsodnj2o@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account.
  3. Complete onboarding.
  4. Create a workspace.
  5. Go to workspace settings > Overview.
  6. Click Plan and upgrade to Control.
  7. Go to More features > Rules.
  8. Go to Rules.
    → Note that Receipt required amount, Max expense amount and Max expense age are populated with default value.
  9. Create another workspace.
  10. Go to More features > Rules.

Expected Result:

For each new subsequent workspace, Receipt required amount, Max expense amount and Max expense age will be populated with default value.

Actual Result:

For each new subsequent workspace, Receipt required amount, Max expense amount and Max expense age are set to 0.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6909800_1754518771491.20250807_061515.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021953511617177925706
  • Upwork Job ID: 1953511617177925706
  • Last Price Increase: 2025-08-07
Issue OwnerCurrent Issue Owner: @QichenZhu

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 7, 2025
  2. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Aug 7, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. 10 remaining items

  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 7, 2025
  8. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

  9. daledah commented on Aug 7, 2025

    @daledah
    Contributor

    @neil-marcellini Sorry for the curtly comment, I just looked into this issue briefly and didn't think much of it. Although we already opened the issue, here's my explanation:

    Before #67477, we always create collect policy with CreateWorkspace API, so some of the control-only features and data, such as rule settings values, are not sent with that API. Those data is only received when we call UpgradeToCorporate API.

    After #67477, control policy can be created with CreateWorkspace API, and since UpgradeToCorporate is no longer needed for these policies, the data required is not sent from BE anymore, leading to those values being 0.

    So I think we should update CreateWorkspace API in BE to return needed data if policy being created is control.

  10. neil-marcellini commented on Aug 7, 2025

    @neil-marcellini
    Contributor

    Thanks for explaining more. I think we should revert that frontend PR, because it directly caused the issue. Then we can fix the problem and reapply it.

  11. added
    ReviewingHas a PR in review
    and removed
    DeployBlockerIndicates it should block deploying the API
    Help WantedApply this label when an issue is open to proposals by contributors
    InternalRequires API changes or must be handled by Expensify staff
    on Aug 7, 2025
  12. jasperhuangg commented on Aug 7, 2025

    @jasperhuangg
    Contributor

    Asking for retest here

  13. stitesExpensify commented on Jan 15, 2026

    @stitesExpensify
    Contributor

    @daledah do you know if we still need to update the backend for this one?

  14. daledah commented on Jan 16, 2026

    @daledah
    Contributor

    @stitesExpensify This issue is being worked on in #65697, looks like it's not on priority list yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions