You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workspace - Expense rule settings are set to 0 for subsequent workspaces after first workspace #68070
Version Number: 9.1.90-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#67477 Email or phone of affected tester (no customers):sjodnjsojsodnj2o@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Log in with a new Gmail account.
Complete onboarding.
Create a workspace.
Go to workspace settings > Overview.
Click Plan and upgrade to Control.
Go to More features > Rules.
Go to Rules.
→ Note that Receipt required amount, Max expense amount and Max expense age are populated with default value.
Create another workspace.
Go to More features > Rules.
Expected Result:
For each new subsequent workspace, Receipt required amount, Max expense amount and Max expense age will be populated with default value.
Actual Result:
For each new subsequent workspace, Receipt required amount, Max expense amount and Max expense age are set to 0.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@neil-marcellini Sorry for the curtly comment, I just looked into this issue briefly and didn't think much of it. Although we already opened the issue, here's my explanation:
Before #67477, we always create collect policy with CreateWorkspace API, so some of the control-only features and data, such as rule settings values, are not sent with that API. Those data is only received when we call UpgradeToCorporate API.
After #67477, control policy can be created with CreateWorkspace API, and since UpgradeToCorporate is no longer needed for these policies, the data required is not sent from BE anymore, leading to those values being 0.
So I think we should update CreateWorkspace API in BE to return needed data if policy being created is control.
Thanks for explaining more. I think we should revert that frontend PR, because it directly caused the issue. Then we can fix the problem and reapply it.
Activity
melvin-bot commentedon Aug 7, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Aug 7, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 7, 2025
Triggered auto assignment to @neil-marcellini (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 7, 2025
💬 A slack conversation has been started in #expensify-open-source
10 remaining items
melvin-bot commentedon Aug 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (
External)daledah commentedon Aug 7, 2025
@neil-marcellini Sorry for the curtly comment, I just looked into this issue briefly and didn't think much of it. Although we already opened the issue, here's my explanation:
Before #67477, we always create collect policy with
CreateWorkspaceAPI, so some of the control-only features and data, such as rule settings values, are not sent with that API. Those data is only received when we callUpgradeToCorporateAPI.After #67477, control policy can be created with
CreateWorkspaceAPI, and sinceUpgradeToCorporateis no longer needed for these policies, the data required is not sent from BE anymore, leading to those values being 0.So I think we should update
CreateWorkspaceAPI in BE to return needed data if policy being created is control.neil-marcellini commentedon Aug 7, 2025
Thanks for explaining more. I think we should revert that frontend PR, because it directly caused the issue. Then we can fix the problem and reapply it.
jasperhuangg commentedon Aug 7, 2025
Asking for retest here
kavimuru commentedon Aug 7, 2025
@jasperhuangg Not reproduced
https://github.com/user-attachments/assets/0153f9c8-c388-4315-a0ef-9ac1bbc42e44
https://github.com/user-attachments/assets/685e86ac-68f4-45cc-9437-9784ac2cef59
stitesExpensify commentedon Jan 15, 2026
@daledah do you know if we still need to update the backend for this one?
daledah commentedon Jan 16, 2026
@stitesExpensify This issue is being worked on in #65697, looks like it's not on priority list yet.