Skip to content

[Due for payment 2025-09-12] [$250] Export - Export has begun modal not dismissed when clicking the background page or device back button #68078

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.90-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #64616
Email or phone of affected tester (no customers): applausetester+dwffs@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: User Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Login to any account with an expense > Go to Expense
  3. Click on the More button and then Export
  4. Click on All Data - expense level,
  5. When the modal appears click on the background page or ESC key or device back button

Note: In mweb, tapping device back button user can navigate to previous page

Expected Result:

Modal is dismissed

Actual Result:

Modal is not dismissed

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6909922_1754532355114.Screen_Recording_2025-08-07_at_4.47.54_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021956414183764788832
  • Upwork Job ID: 1956414183764788832
  • Last Price Increase: 2025-08-15
  • Automatic offers:
    • samranahm | Contributor | 108480723
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @clarajones-expensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 7, 2025
  2. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Aug 7, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Aug 7, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. 68 remaining items

  7. clarajones-expensify commented on Sep 5, 2025

    @clarajones-expensify
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  8. clarajones-expensify commented on Sep 5, 2025

    @clarajones-expensify
    Contributor

    Hi @thesahindia ! Would you fill out the above checklist when you get a chance? thanks!

  9. changed the title [-][Due for payment 2025-09-12] [$250] Export - Export has begun modal not dismissed when clicking the background page or device back button[/-] [+][Due for payment 2025-09-12] [BACK BUTTON] [$250] Export - Export has begun modal not dismissed when clicking the background page or device back button[/+] on Sep 11, 2025
  10. twisterdotcom commented on Sep 11, 2025

    @twisterdotcom
    Contributor

    Hello assignees. We came to the conclusion in #57969 that the back buttons in the app behave inconsistently and in a way that we don't think is ideal, but that fixing the issue is a potentially high cost, low reward situation. We are going to start tracking these issues and attempt to find a way and somebody who can help solve this problem heuristically across the app.

    I have HELD a lot of issues related to the "back button" but any that are currently Reviewing or Due for payment I have not held. If you believe your issue shouldn't be linked or HELD, comment with the explanation and I will review and unlike/remove the hold. Thank you!

  11. thesahindia commented on Sep 11, 2025

    @thesahindia
    Member

    @twisterdotcom, this was a simple issue and we followed the app design. We were missing the logic to dismiss the modal, we only added that here.

  12. thesahindia commented on Sep 11, 2025

    @thesahindia
    Member

    Hi @thesahindia ! Would you fill out the above checklist when you get a chance? thanks!

    No need for checklist, the logic was intentionally removed in the past and we just added it back. We should just add a regression test case.

    Test 1

    Submit an expense to any workspace
    Open expense report and click more button
    Select Export option and "All Data - expense level"
    Verify Export In progress modal appears
    Verify that the modal gets dismissed upon clicking outside the modal

    Test 2

    Open report page and select a transaction
    Click the select menu and Select Export option then "All Data - expense level"
    Verify Export In progress modal appears
    Verify that the modal gets dismissed upon clicking outside the modal

  13. changed the title [-][Due for payment 2025-09-12] [BACK BUTTON] [$250] Export - Export has begun modal not dismissed when clicking the background page or device back button[/-] [+][Due for payment 2025-09-12] [$250] Export - Export has begun modal not dismissed when clicking the background page or device back button[/+] on Sep 11, 2025
  14. clarajones-expensify commented on Sep 12, 2025

    @clarajones-expensify
    Contributor

    Payment Summary

    Contributor: @samranahm paid $250 via Upwork
    Contributor+: @thesahindia due $250 via NewDot

  15. trjExpensify commented on Apr 9, 2026

    @trjExpensify
    Contributor

    approved $250 for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions