[Due for payment 2025-09-02] [$250] Expense Chat - System message missing hyperlink

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176730/test-cases/41237113
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Macbook, Sequoia 15.6, Chrome, Desktop
App Component: Chat Report View

Action Performed:

Go to https://staging.new.expensify.com/
Sign up with a Gmail address that includes a +
Select “Track and budget expenses”. Click Skip on the remaining steps until the onboarding flow is completed
Create a workspace > Create a report > Create 2 manual expenses
Check both expenses > Click the “2 selected” button > Move expenses > Remove from report
Go to your self DM
Click on one of the removed expenses

Expected Result:

System message should include a hyperlink.

Actual Result:

System message is shown without a hyperlink.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6909833_1754522338789.Skreen_Recording_2025-08-06_at_8.05.40_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021953849909154560167
Upwork Job ID: 1953849909154560167
Last Price Increase: 2025-08-08

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense Chat - System message missing hyperlink

What is the root cause of that problem?

We do not have anchor tag for unreportedTransaction translation

App/src/languages/en.ts

Line 1060 in 403006c

unreportedTransaction: 'moved this expense to your personal space',

What changes do you think we should make in order to solve the problem?

Add anchor tag as we do for movedTransaction.

App/src/languages/en.ts

Line 1059 in 403006c

    
           movedTransaction: ({reportUrl, reportName}: MovedTransactionParams) => `moved this expense${reportName ? ` to <a href="${reportUrl}">${reportName}</a>` : ''}`,

Update all files which are using unreportedTransaction, CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION. and also update all translation files.
Create a new util function like getMovedTransactionMessage.
We can get the self dm report ID using const selfDMReportID = ReportUtils.findSelfDMReportID();
Instead of using report name, we can use personal space and create translations for it.

function getUnreportedTransactionMessage(report: OnyxEntry<Report>) {
    const reportName = getReportName(report) ?? report?.reportName ?? '';
    const reportUrl = `${environmentURL}/r/${report?.reportID}`;
    const message = translateLocal('iou.unreportedTransaction', {
        reportUrl,
        reportName,
    });
    return message;
}

} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION) {
    const selfDMReportID = findSelfDMReportID();
    const toReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${selfDMReportID}`];
    children = (
        <ReportActionItemBasicMessage message="">
            <RenderHTML html={`<comment><muted-text>${getUnreportedTransactionMessage(toReport)}</muted-text></comment>`} />
        </ReportActionItemBasicMessage>
    );
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

the system msg when moving the report doesn't include hyper link.

What is the root cause of that problem?

We're getting system generated msg in the report from here.

App/src/pages/home/report/PureReportActionItem.tsx

Line 1143 in 69d1f32

    
           children = <ReportActionItemBasicMessage message={translate('iou.unreportedTransaction')} />;

As you can see this is a simple text not a link.

What changes do you think we should make in order to solve the problem?

Question by myself.

It is not very clear from the OP what result do we want. It says 'it should include hyperlink'
Do they mean the whole current system msg should be a hyperlink or we should concatenate an extra text with system msg like 'click here' and only that 'click here' part should be a hyperlink.

solution starts here.

We can wrap the text with existing TextLink component.

            const chatReportID = report?.chatReportID;

           children =  <TextLink
                            onPress={() => {
                                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chatReportID));
                            }}

                        >
                            <ReportActionItemBasicMessage message={translate('iou.unreportedTransaction')} />                        
                        </TextLink>;

If we're just adding extra text in the existing system msg 'click here' and only that extra text is a hyperlink then we can just add that extra text and only wrap that text with TextLink.

NOTE

If we are looking to make all the all system generated msgs a hyper link

like here:

App/src/pages/home/report/PureReportActionItem.tsx

Line 1151 in 69d1f32

    
           children = <ReportActionItemBasicMessage message={getWorkspaceNameUpdatedMessage(action)} />;

and here:

App/src/pages/home/report/PureReportActionItem.tsx

Line 1153 in 69d1f32

    
           children = <ReportActionItemBasicMessage message={getWorkspaceCurrencyUpdateMessage(action)} />;

and in many other places(you can check them all out as they're side by side) in the PureReportActionItem.tsx component.

Then we can wrap all of them inside our existing TextLink component and pass appropriate onPress.

Did not include all these cases because the proposal would have gotten very long. But I think you guys get the gist.

Sorry for the long-ass proposal.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Optionally: We can also wrap it inside PressableWithoutFeedback instead of TextLink Both would work.

@JmillsExpensify

@JmillsExpensify @luacmartins we're expecting a hyperlink on personal space here, right? To link to the selfDM.

@trjExpensify

@trjExpensify, We're using <TextLink /> in the video But we can also use <PressableWithoutFeedback /> .

Screen.Recording.2025-08-08.at.2.mp4

@JmillsExpensify

@JmillsExpensify @luacmartins we're expecting a hyperlink on personal space here, right? To link to the selfDM.

Yea, it should be consistent with the report case

Job added to Upwork: https://www.upwork.com/jobs/~021953849909154560167

@Ollyws

@Ollyws @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@Ollyws

👋 checklist time, @Ollyws!

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/58020/files#r2316865161
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Go to https://staging.new.expensify.com/
2. Sign up with a Gmail address that includes a +
3. Select “Track and budget expenses”. Click Skip on the remaining steps until the onboarding flow is completed
4. Create a workspace > Create a report > Create 2 manual expenses
5. Check both expenses > Click the “2 selected” button > Move expenses > Remove from report
6. Go to your self DM
7. Click on one of the removed expenses
8. Verify system message includes a hyperlink for "personal space" test

Do we agree 👍 or 👎

@Ollyws

Payment Summary

Upwork Job

Reviewer: @Ollyws owed $250 via NewDot
Reviewer: @Krishna2323 owed $250 via NewDot

BugZero Checklist (@trjExpensify)

(if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1953849909154560167/hired)
I have verified the PR was not reverted
I have applied any discounts due to bugs/regressions introduced by this PR
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@Krishna2323

This was caught by Applause in a test case, so I'm going to forgo the extra case.

Payment summary as follows:

$250 to @Krishna2323 for the PR
$250 to @Ollyws for the C+ review

You can both go ahead and request. Closing, thanks!

Requested in NewDot!

Requested in ND.

@Krishna2323

$250 approved for @Krishna2323

@Ollyws

$250 approved for @Ollyws

[Due for payment 2025-09-02] [$250] Expense Chat - System message missing hyperlink #68093

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 7, 2025

Krishna2323 commented on Aug 7, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Result

aadil42 commented on Aug 7, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Question by myself.

solution starts here.

NOTE

Sorry for the long-ass proposal.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

trjExpensify commented on Aug 8, 2025

aadil42 commented on Aug 8, 2025

luacmartins commented on Aug 8, 2025

melvin-bot commented on Aug 8, 2025

23 remaining items

melvin-bot commented on Aug 26, 2025

trjExpensify commented on Sep 2, 2025

Ollyws commented on Sep 2, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

melvin-bot commented on Sep 2, 2025

Payment Summary

BugZero Checklist (@trjExpensify)

trjExpensify commented on Sep 3, 2025

Krishna2323 commented on Sep 4, 2025

Ollyws commented on Sep 4, 2025

flaviadefaria commented on Sep 8, 2025

JmillsExpensify commented on Oct 14, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions