You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-02] [$250] Accounting - Resizing the window on the QBD setup page should not trigger any error #68226
Version Number: v9.1.91-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#66773 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Web, Desktop App Component: Workspace Settings
What changes do you think we should make in order to solve the problem?
BTW it was implemented here to address mobile platform so it should only navigate for mobile by using isMobile check
We can do the same here but for this as the code also applies for native platforms we will also need to add an isNative (getPlatform() ,IOS, ANDROID) check.
In place of isMObile check we can use MOBILE_WEB check on getPlatform passing shouldMobileWebBeDistinctFromWeb
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
changed the title [-]Accounting - Resizing the window on the QBD setup page should not trigger any error[/-][+][$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/+]on Aug 11, 2025
changed the title [-][$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/-][+][Due for payment 2025-09-02] [$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/+]on Aug 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@muttmuure The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Aug 8, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Aug 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Accounting - Resizing the window on the QBD setup page should not trigger any error
What is the root cause of that problem?
We are navigating to the
POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODALbased on the screen size here for small screen sizeApp/src/components/ConnectToQuickbooksDesktopFlow/index.tsx
Lines 11 to 14 in b743652
App/src/pages/workspace/accounting/utils.tsx
Lines 71 to 72 in b743652
What changes do you think we should make in order to solve the problem?
BTW it was implemented here to address mobile platform so it should only navigate for mobile by using
isMobilecheckWe can do the same here but for this as the code also applies for native platforms we will also need to add an isNative (getPlatform() ,IOS, ANDROID) check.
In place of isMObile check we can use
MOBILE_WEBcheck on getPlatform passing shouldMobileWebBeDistinctFromWebWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Aug 11, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021955006124261114142
[-]Accounting - Resizing the window on the QBD setup page should not trigger any error[/-][+][$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/+]melvin-bot commentedon Aug 11, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (
External)allgandalf commentedon Aug 12, 2025
Proposal from @FitseTLT LGTM!
🎀 👀 🎀 C+ reviewed
14 remaining items
[-][$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/-][+][Due for payment 2025-09-02] [$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/+]melvin-bot commentedon Aug 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 26, 2025
@allgandalf @muttmuure The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Sep 4, 2025
@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!
FitseTLT commentedon Sep 8, 2025
@muttmuure Payment overdue
melvin-bot commentedon Sep 8, 2025
@muttmuure Still overdue 6 days?! Let's take care of this!
muttmuure commentedon Sep 11, 2025
Payment Summary
Contributor: @FitseTLT paid $250 via Upwork
Contributor+: @allgandalf paid $250 via Upwork