Skip to content

[Due for payment 2025-09-02] [$250] Accounting - Resizing the window on the QBD setup page should not trigger any error #68226

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #66773
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Web, Desktop
App Component: Workspace Settings

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Sign up with a Gmail address that includes a +
  3. Select Track and budget expenses. Complete the flow by skipping the remaining steps.
  4. Create a workspace.
  5. Go to more features > Toggle on 'Accounting' > go to Accounting.
  6. Click 'Connect' button in QBD
  7. Click Upgrade > Got it, thanks > Done
  8. Disconnect QBD by clicking the three dots menu
  9. Click 'Connect' button in QBD again
  10. Reduce the window size

Expected Result:

Resizing the window on QBD setup page should not trigger any error.

Actual Result:

An error is thrown after resizing the window on QBD setup page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021955006124261114142
  • Upwork Job ID: 1955006124261114142
  • Last Price Increase: 2025-08-11
  • Automatic offers:
    • allgandalf | Reviewer | 108392676
    • FitseTLT | Contributor | 108392679
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 8, 2025
  2. melvin-bot commented on Aug 8, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. FitseTLT commented on Aug 8, 2025

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Accounting - Resizing the window on the QBD setup page should not trigger any error

    What is the root cause of that problem?

    We are navigating to the POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODAL based on the screen size here for small screen size

    useEffect(() => {
    if (isSmallScreenWidth) {
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODAL.getRoute(policyID));
    } else {

    if (isSmallScreenWidth) {
    return ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODAL.getRoute(policyID);

    What changes do you think we should make in order to solve the problem?

    BTW it was implemented here to address mobile platform so it should only navigate for mobile by using isMobile check

    We can do the same here but for this as the code also applies for native platforms we will also need to add an isNative (getPlatform() ,IOS, ANDROID) check.
    In place of isMObile check we can use MOBILE_WEB check on getPlatform passing shouldMobileWebBeDistinctFromWeb

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N / A

    What alternative solutions did you explore? (Optional)

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 11, 2025
  5. melvin-bot commented on Aug 11, 2025

    @melvin-bot
  6. changed the title [-]Accounting - Resizing the window on the QBD setup page should not trigger any error[/-] [+][$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/+] on Aug 11, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 11, 2025
  8. melvin-bot commented on Aug 11, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

  9. allgandalf commented on Aug 12, 2025

    @allgandalf
    Contributor

    Proposal from @FitseTLT LGTM!

    🎀 👀 🎀 C+ reviewed

  10. 14 remaining items

  11. changed the title [-][$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/-] [+][Due for payment 2025-09-02] [$250] Accounting - Resizing the window on the QBD setup page should not trigger any error[/+] on Aug 26, 2025
  12. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-02. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    @allgandalf @muttmuure The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on Sep 4, 2025

    @melvin-bot

    @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. FitseTLT commented on Sep 8, 2025

    @FitseTLT
    Contributor

    @muttmuure Payment overdue

  17. melvin-bot commented on Sep 8, 2025

    @melvin-bot

    @muttmuure Still overdue 6 days?! Let's take care of this!

  18. muttmuure commented on Sep 11, 2025

    @muttmuure
    Contributor

    Payment Summary

    Contributor: @FitseTLT paid $250 via Upwork
    Contributor+: @allgandalf paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions