You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-17] [$250] Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user #68235
Version Number: 9.1.91-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41236545 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: MacBook Air 15.5 Chrome, iPhone 15 iOS 18.5 Safari App Component: Left Hand Navigation (LHN)
Action Performed:
Sign in to ND with a brand new gmail account without +
On the onboarding select "Track and budget" option
On the "Stay organized with a workspace" click "Create workspace"
Complete the onboarding
Observe the #admins and Concierge chat in LHN - there are a trial banner on each of them
Open the Concierge chat - the banner disappears (if not, refresh the page)
Expected Result:
"Trial: 30 days left" banner is shown one time in the LHN
Actual Result:
"Trial: 30 days left" banner is shown on #admins and Concierge chat. After opening Concierge chat the banner disappears
here we check the user choose MANAGE_TEAM return admin room else concierge chat for all other onboardingPurposeSelected that is the reason we get the banner on concierge chat instead of just admin room
What changes do you think we should make in order to solve the problem?
we should explicitly check where we are going to post the tasks like we did here
// Guides and onboarding tasks are posted to the #admins room to facilitate the onboarding process.returnshouldPostTasksInAdminsRoom(onboardingPurposeSelected) ? isAdminRoom(optionOrReport) : ((optionOrReportasOptionData)?.isConciergeChat??isConciergeChatReport(optionOrReport));
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user
What is the root cause of that problem?
In the function, isChatUsedForOnboarding we use onboarding value from file subscription so the badge first appears on the concierge when onboarding.chatReportID didn't exist and then when the value is set by the completeOnboarding the badge will also appear on the admin room (onboarding chat report)
and the change in value of onboarding doesn't cause a re-render on the concierge LHN (because of file subscription of onboarding value used in the function) so the badge will also remain on concierge until next re-render
What changes do you think we should make in order to solve the problem?
was added in here as the comment describes to show the badge on the onboarding admin room for the cases we post onboarding tasks to the onboarding admin room but at the time of its implementation onboarding tasks to the onboarding admin room were only created for MANAGE_TEAM with emails that donot have + but after that in here we added engagementChoice of TRACK_WORKSPACE to the condition
We will check isAdminRoom if shouldPostTasksInAdminsRoom is true to show the badge on the onboarding admin chat for the case of shouldPostTasksInAdminsRoom
return shouldPostTasksInAdminsRoom(onboardingPurposeSelected) ? isAdminRoom(optionOrReport) : ((optionOrReport as OptionData)?.isConciergeChat ?? isConciergeChatReport(optionOrReport));
But currently we determine whether we shouldPostTasksInAdminsRoom is when we completeOnboarding so in the mean time after creating the workspace (while the choice is PERSONAL_SPEND) the badge is appearing on the concierge temporarily so to avoid that we can return false in isChatUsedForOnboarding if we haven't completed onboarding onboarding?.hasCompletedGuidedSetupFlow and determined whether or not we have created the tasks in admin room. But another alternative is until we complete onboarding we set ONBOARDING_ADMINS_CHAT_REPORT_ID when we created the workspace
so we can use that value as a fallback to onboarding.chatReportID until data is ready or use it to avoid the badge displaying on the concierge.
In addition to that we will need to pass onboarding as a param to isChatUsedForOnboarding by getting the value from useOnyx subscription so that it re-renders value when changes.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
@FitseTLT In believe that based on contributing guides, instead of deleting the original proposal and create a new one after another member post a proposal, we should edit the original one to keep the things transparent. wasn't your original proposal was just about passing the onboarding from onyx because currently it's not updated when we finish onboarding.
changed the title [-]Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user[/-][+][$250] Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user[/+]on Aug 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ikevin127@isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
ikevin127 The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
ikevin127 If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
** ikevin127** If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Sign up with an email that does not contain + (non-testing email).
In onboarding modal choose Track and budget expenses.
Create workspace (via onboarding flow) and complete the onboarding.
Verify that tasks are posted in the #admins chat report as opposed to Concierge.
Verify that the LHN Trial: 30 days left! badge appears on the #admins chat report as opposed to Concierge.
Activity
melvin-bot commentedon Aug 8, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Aug 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user
What is the root cause of that problem?
we display the banner based on
isChatUsedForOnboardinghereApp/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 298 in 0754dfc
inside
isChatUsedForOnboardingwe check foronboarding.chatReportIDApp/src/libs/ReportUtils.ts
Lines 10780 to 10782 in 26c38db
but
onboardingis not available immediately and we reach to final return statementApp/src/libs/ReportUtils.ts
Lines 10789 to 10791 in 26c38db
here we check the user choose
MANAGE_TEAMreturn admin room else concierge chat for all otheronboardingPurposeSelectedthat is the reason we get the banner on concierge chat instead of just admin roomWhat changes do you think we should make in order to solve the problem?
we should explicitly check where we are going to post the tasks like we did here
App/src/libs/ReportUtils.ts
Lines 10199 to 10201 in 26c38db
and create a new util
shouldPostTasksInAdminsRoomin ReportUtils that we will use inprepareOnboardingOnyxDataandisChatUsedForOnboardingand use
shouldPostTasksInAdminsRoomin default return to prevent getting the ConciergeChatReport as onboarding whenshouldPostTasksInAdminsRoomhere
App/src/libs/ReportUtils.ts
Lines 10789 to 10791 in 26c38db
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
we should explicitly check tasks destination and update the final return
App/src/libs/ReportUtils.ts
Lines 10788 to 10791 in 26c38db
to
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
FitseTLT commentedon Aug 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user
What is the root cause of that problem?
In the function, isChatUsedForOnboarding we use
onboardingvalue from file subscription so the badge first appears on the concierge whenonboarding.chatReportIDdidn't exist and then when the value is set by the completeOnboarding the badge will also appear on the admin room (onboarding chat report)App/src/libs/ReportUtils.ts
Lines 10777 to 10791 in b743652
App/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 74 in b743652
and the change in value of
onboardingdoesn't cause a re-render on the concierge LHN (because of file subscription of onboarding value used in the function) so the badge will also remain on concierge until next re-renderWhat changes do you think we should make in order to solve the problem?
BTW the code below
App/src/libs/ReportUtils.ts
Lines 10787 to 10791 in 5479138
was added in here as the comment describes to show the badge on the onboarding admin room for the cases we post onboarding tasks to the onboarding admin room but at the time of its implementation onboarding tasks to the onboarding admin room were only created for
MANAGE_TEAMwith emails that donot have+but after that in here we added engagementChoice ofTRACK_WORKSPACEto the conditionApp/src/libs/ReportUtils.ts
Lines 10199 to 10201 in 5479138
but
isChatUsedForOnboardingwas not updated properly to align with itWe should create a single util
shouldPostTasksInAdminsRoomand use it in both places here
App/src/libs/ReportUtils.ts
Lines 10199 to 10201 in 5479138
and in here
App/src/libs/ReportUtils.ts
Lines 10787 to 10791 in 5479138
We will check isAdminRoom if
shouldPostTasksInAdminsRoomis true to show the badge on the onboarding admin chat for the case of shouldPostTasksInAdminsRoomBut currently we determine whether we shouldPostTasksInAdminsRoom is when we completeOnboarding so in the mean time after creating the workspace (while the choice is
PERSONAL_SPEND) the badge is appearing on the concierge temporarily so to avoid that we can return false in isChatUsedForOnboarding if we haven't completed onboardingonboarding?.hasCompletedGuidedSetupFlowand determined whether or not we have created the tasks in admin room. But another alternative is until we complete onboarding we setONBOARDING_ADMINS_CHAT_REPORT_IDwhen we created the workspaceApp/src/pages/OnboardingWorkspaceConfirmation/BaseOnboardingWorkspaceConfirmation.tsx
Lines 78 to 79 in 5479138
so we can use that value as a fallback to
onboarding.chatReportIDuntil data is ready or use it to avoid the badge displaying on the concierge.In addition to that we will need to pass
onboardingas a param toisChatUsedForOnboardingby getting the value fromuseOnyxsubscription so that it re-renders value when changes.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A
What alternative solutions did you explore? (Optional)
samranahm commentedon Aug 9, 2025
@FitseTLT In believe that based on contributing guides, instead of deleting the original proposal and create a new one after another member post a proposal, we should edit the original one to keep the things transparent. wasn't your original proposal was just about passing the
onboardingfrom onyx because currently it's not updated when we finish onboarding.samranahm commentedon Aug 9, 2025
Proposal updated
Updates
currentUserEmailfrom onyx values instead of passing the param[-]Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user[/-][+][$250] Onboarding - "Trial: 30 days left" banner shown on #admins and Concierge chat for "Track" user[/+]melvin-bot commentedon Aug 11, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021954941495578711028
melvin-bot commentedon Aug 11, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)45 remaining items
melvin-bot commentedon Sep 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.8-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Sep 10, 2025
@ikevin127 @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
isabelastisser commentedon Sep 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
ikevin127 The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
ikevin127 If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
** ikevin127** If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
ikevin127 commentedon Sep 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
+(non-testing email).Track and budget expenses.#adminschat report as opposed to Concierge.Trial: 30 days left!badge appears on the#adminschat report as opposed to Concierge.Do we agree 👍 or 👎.
isabelastisser commentedon Sep 15, 2025
Payment summary:
@ikevin127 requires payment through NewDot Manual Requests for C+ review $250
@samranahm paid in Upwork automatic offer (Contributor) $250
samranahm commentedon Sep 22, 2025
Due for payment
isabelastisser commentedon Sep 22, 2025
All set!