You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-01-11] Button is overlapping with the text in New Room page - Reported by: @thesahindia #6826
replacing View with <ScrollView style={styles.flex1} contentContainerStyle={styles.p5}> will solve the overlap issue and it will also make it scrollable as it is not scrollable right now.
👍 Proposal looks good and this is consistent with what we do on many other views. Are there any more views that are missed that this needs to be added to?
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Button is overlapping with the text in New Room page - Reported by: @thesahindia[/-][+][HOLD for payment 2022-01-11] Button is overlapping with the text in New Room page - Reported by: @thesahindia[/+]on Jan 4, 2022
Sorry, I wasn't sure I could provide a bonus without rehiring you but I added it to the payment from yesterday. Upwork isn't super clear but I see the bonus and Paid job - will you please make sure you get paid for both?
Activity
MelvinBot commentedon Dec 17, 2021
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Dec 20, 2021
Triggered auto assignment to @Christinadobrzyn (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.tgolen commentedon Dec 20, 2021
Issue looks legit, so let's get it out to our open-source community.
thesahindia commentedon Dec 20, 2021
Proposal
replacing
Viewwith<ScrollView style={styles.flex1} contentContainerStyle={styles.p5}>will solve the overlap issue and it will also make it scrollable as it is not scrollable right now.App/src/pages/workspace/WorkspaceNewRoomPage.js
Line 144 in 213751e
tgolen commentedon Dec 20, 2021
👍 Proposal looks good and this is consistent with what we do on many other views. Are there any more views that are missed that this needs to be added to?
🟢 to hire @thesahindia for that proposal.
thesahindia commentedon Dec 20, 2021
@tgolen, will report if I find any.
Christinadobrzyn commentedon Dec 21, 2021
Created Job in Upwork:
Internal posting: https://www.upwork.com/ab/applicants/1473110323714453505/job-details
External posting: https://www.upwork.com/jobs/~01c73faed55a1b6c12
Hired @thesahindia for the job!
11 remaining items
tgolen commentedon Jan 3, 2022
Looks like this issue is just waiting to get deployed since the PR is done and merged. Not sure why it went overdue.
botify commentedon Jan 4, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-01-11. 🎊
[-]Button is overlapping with the text in New Room page - Reported by: @thesahindia[/-][+][HOLD for payment 2022-01-11] Button is overlapping with the text in New Room page - Reported by: @thesahindia[/+]Christinadobrzyn commentedon Jan 12, 2022
Looks like there are no regressions on the PR - so paid @thesahindia in Upwork and closed this job.
thesahindia commentedon Jan 12, 2022
@Christinadobrzyn, can you please add the reporting bonus since I reported this issue.
Christinadobrzyn commentedon Jan 13, 2022
Ah thank you for reminding me @thesahindia! I just added a $250 bonus to the previous Upwork payment.
thesahindia commentedon Jan 13, 2022
Hey @Christinadobrzyn, I think you have sent me an another offer for the same job, should I end that new contract??
Christinadobrzyn commentedon Jan 13, 2022
Yes, please! Feel free to end the contract.
Sorry, I wasn't sure I could provide a bonus without rehiring you but I added it to the payment from yesterday. Upwork isn't super clear but I see the bonus and Paid job - will you please make sure you get paid for both?
thesahindia commentedon Jan 13, 2022
Yes, I have received the payments. Thanks :)