Skip to content

[HOLD for payment 2022-01-11] Button is overlapping with the text in New Room page - Reported by: @thesahindia #6826

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to app
  2. Create a new workspace if you dont have one
  3. Click "+" > New room

Expected Result:

Buttons and text should not overlap

Actual Result:

Button is overlapping with the text in New Room page.
Issue repro on smaller screen devices

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.19-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshot_2021-12-13-00-10-03-632_com android chrome (1)

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639335083137500

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Dec 17, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 20, 2021
  3. MelvinBot commented on Dec 20, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  4. tgolen commented on Dec 20, 2021

    @tgolen
    Contributor

    Issue looks legit, so let's get it out to our open-source community.

  5. thesahindia commented on Dec 20, 2021

    @thesahindia
    Member

    Proposal

    replacing View with <ScrollView style={styles.flex1} contentContainerStyle={styles.p5}> will solve the overlap issue and it will also make it scrollable as it is not scrollable right now.

    <View style={[styles.flex1, styles.w100, styles.pRelative, styles.p5]}>

  6. tgolen commented on Dec 20, 2021

    @tgolen
    Contributor

    👍 Proposal looks good and this is consistent with what we do on many other views. Are there any more views that are missed that this needs to be added to?

    🟢 to hire @thesahindia for that proposal.

  7. thesahindia commented on Dec 20, 2021

    @thesahindia
    Member

    @tgolen, will report if I find any.

  8. Christinadobrzyn commented on Dec 21, 2021

    @Christinadobrzyn
    Contributor
  9. 11 remaining items

  10. tgolen commented on Jan 3, 2022

    @tgolen
    Contributor

    Looks like this issue is just waiting to get deployed since the PR is done and merged. Not sure why it went overdue.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 4, 2022
  12. botify commented on Jan 4, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-01-11. 🎊

  13. changed the title [-]Button is overlapping with the text in New Room page - Reported by: @thesahindia[/-] [+][HOLD for payment 2022-01-11] Button is overlapping with the text in New Room page - Reported by: @thesahindia[/+] on Jan 4, 2022
  14. Christinadobrzyn commented on Jan 12, 2022

    @Christinadobrzyn
    Contributor

    Looks like there are no regressions on the PR - so paid @thesahindia in Upwork and closed this job.

  15. thesahindia commented on Jan 12, 2022

    @thesahindia
    Member

    @Christinadobrzyn, can you please add the reporting bonus since I reported this issue.

  16. Christinadobrzyn commented on Jan 13, 2022

    @Christinadobrzyn
    Contributor

    Ah thank you for reminding me @thesahindia! I just added a $250 bonus to the previous Upwork payment.

  17. thesahindia commented on Jan 13, 2022

    @thesahindia
    Member

    Hey @Christinadobrzyn, I think you have sent me an another offer for the same job, should I end that new contract??

  18. Christinadobrzyn commented on Jan 13, 2022

    @Christinadobrzyn
    Contributor

    Yes, please! Feel free to end the contract.

    Sorry, I wasn't sure I could provide a bonus without rehiring you but I added it to the payment from yesterday. Upwork isn't super clear but I see the bonus and Paid job - will you please make sure you get paid for both?

  19. thesahindia commented on Jan 13, 2022

    @thesahindia
    Member

    Yes, I have received the payments. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions