[Due for payment 2025-10-22] [HOLD #69341][$500] Invoice - Invoice details page opens when clicking Concierge on the whisper in invoice thread

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.92-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-119/folder/13177075/41237841/830240812
Email or phone of affected tester (no customers): sjodijnsojdsoij@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Invoice feature is enabled

Go to staging.new.expensify.com
Go to workspace chat
Submit an expense to workspace chat
Open expense report
Mention a user who is not a member of the report and send the message
Click Concierge on the whisper
→ Concierge profile opens
Open FAB > Send invoice
Send an invoice to any user
Open invoice thread
Mention a user who is not a member of the report and send the message
Click Concierge on the whisper

Expected Result:

Concierge profile opens

Actual Result:

Invoice details page opens when clicking on Concierge on the whisper in invoice thread

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

Bug6913015_1754833179454.Screen_Recording_2025-08-10_at_21.32.21.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021955556600223096668
Upwork Job ID: 1955556600223096668
Last Price Increase: 2025-09-03
Automatic offers:

QichenZhu | Reviewer | 108972310

Issue Owner

Current Issue Owner: @mallenexpensify

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-08-15 02:36:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice details page opens when clicking on Concierge on the whisper in invoice thread

What is the root cause of that problem?

With isWorkspaceActor === true we will display workspace details:

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 114 to 117 in dd11c95

    
           const showActorDetails = useCallback(() => { 
        
               if (details.isWorkspaceActor) { 
        
                   showWorkspaceDetails(reportID); 
        
               } else {

isWorkspaceActor will always be true for invoice reports:

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 149 in dd11c95

const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

What changes do you think we should make in order to solve the problem?

In the case of a workspace actor, the avatar type is displayed as a subscript avatar:

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 171 to 172 in 8dcc9d3

    
           if (shouldUseSubscriptAvatar) { 
        
               avatarType = CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT;

Therefore, we can use the shouldUseSubscriptAvatar condition for isWorkspaceActor.

Why this works: If the avatar is rendered as a subscript avatar, it will definitely require opening the workspace details.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Add a condition to check if it is Concierge then isWorkspaceActor is always false:

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 149 in dd11c95

    
           const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

const isWorkspaceActor = accountID !== CONST.ACCOUNT_ID.CONCIERGE && (isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors)));

Note: We can add a similar Concierge check to displayAllActors to ensure that only the Concierge profile is displayed:

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

🚨 Edited by proposal-police: This proposal was edited at 2025-08-14 03:54:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice details page opens when clicking on Concierge on the whisper in invoice thread

What is the root cause of that problem?

isWorkspaceActor is always true for the invoice report, then any action's avatar in the invoice report will open the report detail page.

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 175 in 15e889b

    
           const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 114 to 119 in 15e889b

    
           const showActorDetails = useCallback(() => { 
        
               if (details.isWorkspaceActor) { 
        
                   showWorkspaceDetails(reportID); 
        
               } else { 
        
                   // Show participants page IOU report preview 
        
                   if (iouReportID && details.shouldDisplayAllActors) {

What changes do you think we should make in order to solve the problem?

isWorkspaceActor should only true if the report action is report preview

const isWorkspaceActor = isAReportPreviewAction && (isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors)));

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 175 in 15e889b

    
           const isWorkspaceActor = isAInvoiceReport || (isAWorkspaceChat && (!actorAccountID || displayAllActors));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

I'll open this up since there are proposals though I'm also adding weekly since this is lower priority.

Job added to Upwork: https://www.upwork.com/jobs/~021955556600223096668

Reviewing label has been removed, please complete the "BugZero Checklist".

@QichenZhu

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.31-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix/68262 - Invoice details page opens when clicking on Concierge on the whisper in invoice thread #71907

If no regressions arise, payment will be issued on 2025-10-22. 🎊

For reference, here are some details about the assignees on this issue:

@QichenZhu requires payment automatic offer (Reviewer)
@dmkt9 requires payment (Needs manual offer from BZ)

@QichenZhu

@QichenZhu @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@dmkt9

Payment Summary

Contributor: @dmkt9 paid $500 via Upwork
Contributor+: @QichenZhu paid $500 via Upwork.

@dmkt9 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~021981122719476224114

@QichenZhu plz complete the BZ checklist.

BugZero Checklist:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: [Avatars - Reports] Use centralized logic for report actions avatars everywhere in the app #65740 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

If the regression test mentioned in OP already caught this, no new one is needed. Otherwise, below is a proposed test.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Invoice feature is enabled

Test:

Tap FAB > Send Invoice
Send an invoice to any user
Open the invoice thread
Mention a user who is not a member of the report and send the message
Tap the avatar on the Concierge message
Verify that the Concierge profile opens

Do we agree 👍 or 👎

@mallenexpensify

@mallenexpensify Thanks. I have just requested payment on Upwork.

@dmkt9

@dmkt9 paid, summary updated above.

Test case created, thx!

https://github.com/Expensify/Expensify/issues/560616

Navigation Menu

Repository navigation

[Due for payment 2025-10-22] [HOLD #69341][$500] Invoice - Invoice details page opens when clicking Concierge on the whisper in invoice thread #68262

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

94 remaining items

Payment Summary

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const showActorDetails = useCallback(() => {
	if (details.isWorkspaceActor) {
	showWorkspaceDetails(reportID);
	} else {

	if (shouldUseSubscriptAvatar) {
	avatarType = CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT;

[Due for payment 2025-10-22] [HOLD #69341][$500] Invoice - Invoice details page opens when clicking Concierge on the whisper in invoice thread #68262

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 10, 2025

dmkt9 commented on Aug 11, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

nkdengineer commented on Aug 12, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

JmillsExpensify commented on Aug 13, 2025

melvin-bot commented on Aug 13, 2025

94 remaining items

melvin-bot commented on Oct 15, 2025

melvin-bot commented on Oct 15, 2025

melvin-bot commented on Oct 15, 2025

mallenexpensify commented on Oct 22, 2025

Payment Summary

QichenZhu commented on Oct 22, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

dmkt9 commented on Oct 22, 2025

mallenexpensify commented on Oct 24, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions