Skip to content

[Due for payment 2025-09-12] [$250] "Uncaught SyntaxError" when navigating to the "Free Features In Expensify" help #68418

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.93-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #68292
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Other

Action Performed:

  1. Navigate to https://help.expensify.com/ in Chrome incognito
  2. Navigate to "New Expensify" - "Getting Started" - "Free Features In Expensify"

Expected Result:

Console error shouldn't be showing.

Actual Result:

"Uncaught SyntaxError" console error when navigating to the "Free Features In Expensify" help page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6915206_1755026399724.bandicam_2025-08-12_21-02-05-053.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021958023358169533306
  • Upwork Job ID: 1958023358169533306
  • Last Price Increase: 2025-08-20
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 13, 2025
  2. melvin-bot commented on Aug 13, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. dmkt9 commented on Aug 13, 2025

    @dmkt9
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Uncaught SyntaxError" console error when navigating to the "Free Features In Expensify" help page.

    What is the root cause of that problem?

    svg:([data-source]) is an invalid selector

    What changes do you think we should make in order to solve the problem?

    We should change it to svg[data-source]

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. NJ-2020 commented on Aug 13, 2025

    @NJ-2020
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Uncaught SyntaxError" when navigating to the "Free Features In Expensify" help

    What is the root cause of that problem?

    We pass invalid selector here:

    const svgsGoogle = document.querySelectorAll('svg:([data-source])');

    What changes do you think we should make in order to solve the problem?

    Change it to:

    const svgsGoogle = document.querySelectorAll('svg[data-source]');

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

  5. adelekennedy commented on Aug 20, 2025

    @adelekennedy
    Contributor

    Same result - I don't know that this has much impact n the user but seems like we should fix?

  6. changed the title [-]"Uncaught SyntaxError" when navigating to the "Free Features In Expensify" help[/-] [+][$250] "Uncaught SyntaxError" when navigating to the "Free Features In Expensify" help[/+] on Aug 20, 2025
  7. melvin-bot commented on Aug 20, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 20, 2025
  9. melvin-bot commented on Aug 20, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  10. 25 remaining items

  11. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @mananjadhav owed $250 via NewDot
    • ROLE: @dmkt9 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@VictoriaExpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1958023358169533306/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. mallenexpensify commented on Sep 15, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @dmkt9 paid $250 via Upwork,
    Contributor+: @mananjadhav due $250 via NewDot, awaiting BZ checklist.

    @dmkt9 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~021958023358169533306

  13. dmkt9 commented on Sep 16, 2025

    @dmkt9
    Contributor

    @mallenexpensify Thanks. I have just requested payment on Upwork.

  14. mallenexpensify commented on Sep 16, 2025

    @mallenexpensify
    Contributor

    Thanks, paid! Payment summary updated above

  15. mallenexpensify commented on Sep 16, 2025

    @mallenexpensify
    Contributor

    Strike that, I think we need the BZ checklist filled out... right? @mananjadhav , can you do so? I think/hope the below is the current version.

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  16. mananjadhav commented on Sep 16, 2025

    @mananjadhav
    Collaborator

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: 01f0b7f#r165894141

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    I don't think we need a regression test for this one. This isn't going to change much and it's a part of the docs page.

  17. mananjadhav commented on Sep 16, 2025

    @mananjadhav
    Collaborator

    @mallenexpensify Checklist done.

  18. quinthar commented on Sep 17, 2025

    @quinthar
    Contributor

    $250 approved to @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions