Skip to content

[Due for payment 2025-09-02] [$250] [HELP PANEL] Update the logic and fix help panel appearing without NVP #68462

Closed

Description

@blazejkustra

According to requirements from this thread and this thread we need to make some changes to the side panel:

  • Fix bug where help button was visible for people without the NVP
  • Add support for ordered list on help panel
  • Split chat help content into two sections
  • Regenerate help content
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021958443488218896064
  • Upwork Job ID: 1958443488218896064
  • Last Price Increase: 2025-08-21
  • Automatic offers:
    • dominictb | Reviewer | 108493026
Issue OwnerCurrent Issue Owner: @lydiabarclay

Activity

  1. melvin-bot commented on Aug 20, 2025

    @melvin-bot

    Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 21, 2025
  3. changed the title [-][HELP PANEL] Update the logic and fix help panel appearing without NVP[/-] [+][$250] [HELP PANEL] Update the logic and fix help panel appearing without NVP[/+] on Aug 21, 2025
  4. melvin-bot commented on Aug 21, 2025

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 21, 2025
  6. melvin-bot commented on Aug 21, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  7. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 21, 2025
  8. 18 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 21, 2025
  10. changed the title [-][$250] [HELP PANEL] Update the logic and fix help panel appearing without NVP[/-] [+][Due for payment 2025-09-02] [$250] [HELP PANEL] Update the logic and fix help panel appearing without NVP[/+] on Aug 26, 2025
  11. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.98-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-02. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Aug 26, 2025

    @melvin-bot

    @dominictb @lydiabarclay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. lydiabarclay commented on Aug 29, 2025

    @lydiabarclay
    Contributor

    @dominictb could you fill out the BZ checklist before 9/2? Tysm! I will be out for the long weekend so wanted to make sure I pinged before that date.

  15. lydiabarclay commented on Sep 2, 2025

    @lydiabarclay
    Contributor

    Payment Summary

    Contributor: @blazejkustra does not require payment (Contractor)
    Contributor+: @dominictb paid $250 via Upwork

    ✅ Regression test filed

  16. dominictb commented on Sep 3, 2025

    @dominictb
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: Help content update

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other: Help content update

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA. Help content update.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/543442

    Regression Test Proposal

    Precondition:

    • Help panel beta is enabled

    Test:

    1. Go to workspace settings > Members
    2. Press help button
    3. Verify content under "Adding Members" section has a numbered list
    4. Go to any workspace chat
    5. Press help button > "Show more"
    6. Verify "Inbox" section shows in help page

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions