You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-12] [Due for payment 2025-09-02] [$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation #68518
In the OP’s case, strikethrough is used outside and fully wraps the blockquote, so it gets rendered first and becomes the parent of the blockquote's span. However, because blockquote is set to inline-block, the styles from the strikethrough's span don’t cascade down to the blockquote's span.
What changes do you think we should make in order to solve the problem?
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/-][+][$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/+]on Aug 15, 2025
@dmkt9's proposal looks good to me, the RCA is correct and the proposed main solution fixes the issue following existing patterns within the react-native-live-markdown library.
Screen.Recording.2025-08-15.at.16.53.15.mov
Additionally I tested the changes directly in the react-native-live-markdown library to ensure all tests are still passing 🟢 Noting that the issue is only present in web-based platforms, this issue is not reproducible on Native.
This will require a react-native-live-markdown PR first, then a version bump PR for Expensify/App. For the react-native-live-markdown I suggest adding the following webParser tests to cover the new logic proposed in the main solution:
changed the title [-][Due for payment 2025-09-02] [$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/-][+][Due for payment 2025-09-12] [Due for payment 2025-09-02] [$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/+]on Sep 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.1-20 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ikevin127@isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
ikevin127 The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
ikevin127 If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
ikevin127 If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A: result of the original design coming from the react-native-live-markdown library.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Open app.
Open a chat.
Paste this text:
~Test
> Quote
Test~
Send the message.
Paste the message again in the composer and verify that the preview is consistent with the sent message.
Activity
melvin-bot commentedon Aug 14, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.aadil42 commentedon Aug 14, 2025
@jponikarchuk the text provided in the OP is not consistent with the one used in the video. Can you give me that text?
jponikarchuk commentedon Aug 14, 2025
@aadil42 The text provided in the OP is correct too
bandicam.2025-08-14.11-50-53-332.mp4
dmkt9 commentedon Aug 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
In preview, strike through is not applied for quote markdown text but in conversation view, strike through markdown is applied.
What is the root cause of that problem?
Since
blockquoteinreact-native-live-markdownis styled withdisplay: 'inline-block':https://github.com/Expensify/react-native-live-markdown/blob/c5aeea4397e29012241f6e0aa934e11f75c36350/src/web/utils/blockUtils.ts#L58-L62
In the OP’s case,
strikethroughis used outside and fully wraps theblockquote, so it gets rendered first and becomes the parent of theblockquote's span. However, becauseblockquoteis set toinline-block, the styles from thestrikethrough's span don’t cascade down to theblockquote's span.What changes do you think we should make in order to solve the problem?
In this case, we should check whether the
blockquoteis wrapped by astrikethrough. If it is, we can manually apply thestrikethroughstyles to theblockquote’s span.https://github.com/Expensify/react-native-live-markdown/blob/c5aeea4397e29012241f6e0aa934e11f75c36350/src/web/utils/parserUtils.ts#L238
+ const parsedLineMarkdownRanges = [] as MarkdownRange[];https://github.com/Expensify/react-native-live-markdown/blob/c5aeea4397e29012241f6e0aa934e11f75c36350/src/web/utils/parserUtils.ts#L266
https://github.com/Expensify/react-native-live-markdown/blob/c5aeea4397e29012241f6e0aa934e11f75c36350/src/web/utils/parserUtils.ts#L300
+ parsedLineMarkdownRanges.push(range); }Note: We can review other markdown combinations that may require similar manual handling and apply this approach where necessary.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Option 1: Add
textDecoration: 'inherit'style toblockquote:With this approach, we need to apply
textDecoration: 'inherit'to all elements that might wrap around ablockquote, such asbold,italic, etc.https://github.com/Expensify/react-native-live-markdown/blob/c5aeea4397e29012241f6e0aa934e11f75c36350/src/web/utils/blockUtils.ts#L58
Option 2: Remove the
inline-blockstyle fromblockquote:https://github.com/Expensify/react-native-live-markdown/blob/c5aeea4397e29012241f6e0aa934e11f75c36350/src/web/utils/blockUtils.ts#L62
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/-][+][$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/+]melvin-bot commentedon Aug 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021956328079456092450
melvin-bot commentedon Aug 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)ikevin127 commentedon Aug 16, 2025
@dmkt9's proposal looks good to me, the RCA is correct and the proposed main solution fixes the issue following existing patterns within the
react-native-live-markdownlibrary.Screen.Recording.2025-08-15.at.16.53.15.mov
Additionally I tested the changes directly in the
react-native-live-markdownlibrary to ensure all tests are still passing 🟢Noting that the issue is only present in web-based platforms, this issue is not reproducible on Native.
This will require a
react-native-live-markdownPR first, then a version bump PR forExpensify/App. For thereact-native-live-markdownI suggest adding the followingwebParsertests to cover the new logic proposed in the main solution:Tests DIFF
🎀👀🎀 C+ reviewed
35 remaining items
[-][Due for payment 2025-09-02] [$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/-][+][Due for payment 2025-09-12] [Due for payment 2025-09-02] [$250] Chat - Strikethrough not applied to blockquote text in preview, but applied in conversation[/+]melvin-bot commentedon Sep 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.1-20 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-09-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Sep 5, 2025
@ikevin127 @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
isabelastisser commentedon Sep 7, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
ikevin127 The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
ikevin127 If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
ikevin127 If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
isabelastisser commentedon Sep 9, 2025
Bump @ikevin127
ikevin127 commentedon Sep 9, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A: result of the original design coming from the
react-native-live-markdownlibrary.[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Do we agree 👍 or 👎.
isabelastisser commentedon Sep 12, 2025
Payment summary:
C+ review: @ikevin127 owed $250 via NewDot
ROLE: @dmkt9 paid $250 via Upwork (LINK)
isabelastisser commentedon Sep 12, 2025
All set!
dmkt9 commentedon Sep 12, 2025
@isabelastisser Thanks. I have just requested payment on Upwork.
twisterdotcom commentedon Sep 16, 2025
@ikevin127 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-6203-af3d-ad5f-a78e6b42ad91