Skip to content

[Will pay 09-02][Due for payment 2025-08-29] $125 Remove Onyx.connect() for the key: ONYXKEYS.NVP_ONBOARDING in src/libs/actions/Welcome/index.ts #68636

Closed

Description

@danieldoglas

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @clarajones-expensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 18, 2025
  2. danieldoglas commented on Aug 18, 2025

    @danieldoglas
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. melvin-bot commented on Aug 18, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added
    ReviewingHas a PR in review
    and removed on Aug 18, 2025
  5. 6 remaining items

  6. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.97-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-29. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment through NewDot Manual Requests
    • @DylanDylann requires payment through NewDot Manual Requests
  8. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    @ikevin127 / @DylanDylann @clarajones-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. clarajones-expensify commented on Aug 26, 2025

    @clarajones-expensify
    Contributor

    Hi @DylanDylann @ikevin127 ! I wanted to let you know that I will be OOO on Friday Aug 29 when payment is due, as well the following Monday Sept 1 (which is a US holiday). Are you okay if I finalize payment when I return on Sept 2, or would you prefer that I assign one of my teammates to handle payment on Aug 29?

    Let me know what you prefer. Thanks!

  10. changed the title [-][Due for payment 2025-08-29] $125 Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_ONBOARDING` in `src/libs/actions/Welcome/index.ts`[/-] [+][Will pay 09-02][Due for payment 2025-08-29] $125 Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_ONBOARDING` in `src/libs/actions/Welcome/index.ts`[/+] on Aug 27, 2025
  11. ikevin127 commented on Aug 27, 2025

    @ikevin127
    Contributor

    @clarajones-expensify You could simply post the payment summary confirmation before the 29th and we'll request on ND when the 29th payment date is due. No harm in posting the summary earlier given we know the amount ($125) and the issue doesn't require BZ checklist completion based on #68636 (comment).

  12. clarajones-expensify commented on Sep 2, 2025

    @clarajones-expensify
    Contributor

    Payment Summary

    Contributor: @DylanDylann due $125 via NewDot
    Contributor+: @ikevin127 due $125 via NewDot

  13. twisterdotcom commented on Sep 4, 2025

    @twisterdotcom
    Contributor

    @ikevin127 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-0455-a082-9384-fa24d88519e1
  14. garrettmknight commented on Nov 1, 2025

    @garrettmknight
    Contributor

    $125 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions