You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-09-02] Remove keyboard handling logic on native platforms #68644
SearchList(used on the Reports page) includes custom logic that allows user to navigate through list items with keyboard arrow keys(this is implemented with useArrowKeyFocusManager, useKeyboardShortcut, useIsFocused, etc.). While this functionality is useful for web and desktop platforms that support external keyboards, it is not applicable to mobile platforms.
Problem
Custom logic for keyboard handling on SearchList adds additional overhead on platforms that don't use the keyboard and don't need this logic(iOS/Android). According to my measurments this can cause as much as 200 ms of overhead on Android.
Solution
Remove keyboard handling logic on native platforms:
Split SearchList implementation into index.tsx and index.native.tsx.
Remove the keyboard handling logic from index.native.tsx(and make sure no code duplication between index.tsx and index.native exists).
Alternatively we can create a wrapper for SearchList that adds keyboard handling for the web/desktop and does nothing for native(also with the usage of index/index.native).
Benefits
I've measured total react work in ms and commits when entering Reports page on Android, here are the results:
Before Optimization
changed the title [-][Due for payment 2025-09-02] [HOLD for payment 2025-08-28] Remove keyboard handling logic on native platforms[/-][+][Due for payment 2025-09-02] Remove keyboard handling logic on native platforms[/+]on Sep 16, 2025
Activity
melvin-bot commentedon Aug 18, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.vnvianna commentedon Aug 18, 2025
Okay, testing melvin whitelist (https://github.com/Expensify/Web-Expensify/pull/48166)
linhvovan29546 commentedon Aug 22, 2025
@mountiny @dylanexpensify Could you please assign me here? Since i reviewed this PR #68455 (comment)
13 remaining items
melvin-bot commentedon Sep 2, 2025
Payment Summary
Upwork Job
BugZero Checklist (@dylanexpensify)
melvin-bot commentedon Sep 3, 2025
@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Sep 5, 2025
@dylanexpensify Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Sep 9, 2025
@dylanexpensify 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Sep 11, 2025
@dylanexpensify 12 days overdue now... This issue's end is nigh!
melvin-bot commentedon Sep 15, 2025
This issue has not been updated in over 14 days. @mountiny, @dylanexpensify, @linhvovan29546, @SzymczakJ eroding to Weekly issue.
linhvovan29546 commentedon Sep 16, 2025
@dylanexpensify Could you please handle payment? Thank you!
[-][Due for payment 2025-09-02] [HOLD for payment 2025-08-28] Remove keyboard handling logic on native platforms[/-][+][Due for payment 2025-09-02] Remove keyboard handling logic on native platforms[/+]dylanexpensify commentedon Sep 18, 2025
Payment summary:
Contributor+: @linhvovan29546 $250 via NewDot
Please apply/request!
dylanexpensify commentedon Sep 18, 2025
@linhvovan29546 please apply here!